diff options
| author | Nick Pope <nick.pope@flightdataservices.com> | 2019-10-21 09:55:05 +0100 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-10-29 12:37:30 +0100 |
| commit | 7552de7866dcd270a0f353b007b4aceaa7f3ff3e (patch) | |
| tree | 2e84292833853d9659671ed304cb32d5acef5f90 /tests/template_tests | |
| parent | a6cb8ec3895a72bfb7f8e62d4b05dd5de6b738af (diff) | |
Used more specific unittest assertions in tests.
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
Diffstat (limited to 'tests/template_tests')
| -rw-r--r-- | tests/template_tests/test_origin.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/tests/template_tests/test_origin.py b/tests/template_tests/test_origin.py index 0e9ee8b1e0..03738a80bd 100644 --- a/tests/template_tests/test_origin.py +++ b/tests/template_tests/test_origin.py @@ -13,12 +13,14 @@ class OriginTestCase(TestCase): a = self.engine.get_template('index.html') b = self.engine.get_template('index.html') self.assertEqual(a.origin, b.origin) - self.assertTrue(a.origin == b.origin) - self.assertFalse(a.origin != b.origin) + # Use assertIs() to test __eq__/__ne__. + self.assertIs(a.origin == b.origin, True) + self.assertIs(a.origin != b.origin, False) def test_origin_compares_not_equal(self): a = self.engine.get_template('first/test.html') b = self.engine.get_template('second/test.html') self.assertNotEqual(a.origin, b.origin) - self.assertFalse(a.origin == b.origin) - self.assertTrue(a.origin != b.origin) + # Use assertIs() to test __eq__/__ne__. + self.assertIs(a.origin == b.origin, False) + self.assertIs(a.origin != b.origin, True) |