From 7552de7866dcd270a0f353b007b4aceaa7f3ff3e Mon Sep 17 00:00:00 2001 From: Nick Pope Date: Mon, 21 Oct 2019 09:55:05 +0100 Subject: Used more specific unittest assertions in tests. * assertIsNone()/assertIsNotNone() instead of comparing to None. * assertLess() for < comparisons. * assertIs() for 'is' expressions. * assertIsInstance() for isinstance() expressions. * rounding of assertAlmostEqual() for round() expressions. * assertIs(..., True/False) instead of comparing to True/False. * assertIs()/assertIsNot() for ==/!= comparisons. * assertNotEqual() for == comparisons. * assertTrue()/assertFalse() instead of comparing to True/False. --- tests/template_tests/test_origin.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'tests/template_tests') diff --git a/tests/template_tests/test_origin.py b/tests/template_tests/test_origin.py index 0e9ee8b1e0..03738a80bd 100644 --- a/tests/template_tests/test_origin.py +++ b/tests/template_tests/test_origin.py @@ -13,12 +13,14 @@ class OriginTestCase(TestCase): a = self.engine.get_template('index.html') b = self.engine.get_template('index.html') self.assertEqual(a.origin, b.origin) - self.assertTrue(a.origin == b.origin) - self.assertFalse(a.origin != b.origin) + # Use assertIs() to test __eq__/__ne__. + self.assertIs(a.origin == b.origin, True) + self.assertIs(a.origin != b.origin, False) def test_origin_compares_not_equal(self): a = self.engine.get_template('first/test.html') b = self.engine.get_template('second/test.html') self.assertNotEqual(a.origin, b.origin) - self.assertFalse(a.origin == b.origin) - self.assertTrue(a.origin != b.origin) + # Use assertIs() to test __eq__/__ne__. + self.assertIs(a.origin == b.origin, False) + self.assertIs(a.origin != b.origin, True) -- cgit v1.3