summaryrefslogtreecommitdiff
path: root/django
diff options
context:
space:
mode:
authorCoen van der Kamp <coen@fourdigits.nl>2023-06-02 12:20:17 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2023-06-05 14:43:51 +0200
commit10d9d0ccb24ebefbcc12f8bc1b90becec64340ee (patch)
tree9a61c4488d8e2c6ce60d02074fc84b58569d9347 /django
parent0faad0193815c5f07a08dba4eaa04193ca9eb268 (diff)
Fixed #34622 -- Improved accessibility of related widget wrapper in admin.
This improves accessibility for screen reader users by adding "aria-disabled" and removing "alt". Thanks Thibaud Colas for the report.
Diffstat (limited to 'django')
-rw-r--r--django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js2
-rw-r--r--django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html8
2 files changed, 6 insertions, 4 deletions
diff --git a/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js b/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js
index afb6b66c25..32e3f5b840 100644
--- a/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js
+++ b/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js
@@ -79,9 +79,11 @@
siblings.each(function() {
const elm = $(this);
elm.attr('href', elm.attr('data-href-template').replace('__fk__', value));
+ elm.removeAttr('aria-disabled');
});
} else {
siblings.removeAttr('href');
+ siblings.attr('aria-disabled', true);
}
}
diff --git a/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html b/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html
index 6c285ea044..805f48b947 100644
--- a/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html
+++ b/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html
@@ -9,7 +9,7 @@
data-href-template="{{ change_related_template_url }}?{{ url_params }}"
data-popup="yes"
title="{% blocktranslate %}Change selected {{ model }}{% endblocktranslate %}">
- <img src="{% static 'admin/img/icon-changelink.svg' %}" alt="{% translate 'Change' %}">
+ <img src="{% static 'admin/img/icon-changelink.svg' %}" alt="">
</a>
{% endif %}
{% if can_add_related %}
@@ -17,7 +17,7 @@
data-popup="yes"
href="{{ add_related_url }}?{{ url_params }}"
title="{% blocktranslate %}Add another {{ model }}{% endblocktranslate %}">
- <img src="{% static 'admin/img/icon-addlink.svg' %}" alt="{% translate 'Add' %}">
+ <img src="{% static 'admin/img/icon-addlink.svg' %}" alt="">
</a>
{% endif %}
{% if can_delete_related %}
@@ -25,14 +25,14 @@
data-href-template="{{ delete_related_template_url }}?{{ url_params }}"
data-popup="yes"
title="{% blocktranslate %}Delete selected {{ model }}{% endblocktranslate %}">
- <img src="{% static 'admin/img/icon-deletelink.svg' %}" alt="{% translate 'Delete' %}">
+ <img src="{% static 'admin/img/icon-deletelink.svg' %}" alt="">
</a>
{% endif %}
{% if can_view_related %}
<a class="related-widget-wrapper-link view-related" id="view_id_{{ name }}"
data-href-template="{{ change_related_template_url }}?{{ view_related_url_params }}"
title="{% blocktranslate %}View selected {{ model }}{% endblocktranslate %}">
- <img src="{% static 'admin/img/icon-viewlink.svg' %}" alt="{% translate 'View' %}">
+ <img src="{% static 'admin/img/icon-viewlink.svg' %}" alt="">
</a>
{% endif %}
{% endif %}