From 10d9d0ccb24ebefbcc12f8bc1b90becec64340ee Mon Sep 17 00:00:00 2001 From: Coen van der Kamp Date: Fri, 2 Jun 2023 12:20:17 +0100 Subject: Fixed #34622 -- Improved accessibility of related widget wrapper in admin. This improves accessibility for screen reader users by adding "aria-disabled" and removing "alt". Thanks Thibaud Colas for the report. --- .../contrib/admin/static/admin/js/admin/RelatedObjectLookups.js | 2 ++ .../admin/templates/admin/widgets/related_widget_wrapper.html | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'django') diff --git a/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js b/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js index afb6b66c25..32e3f5b840 100644 --- a/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js +++ b/django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js @@ -79,9 +79,11 @@ siblings.each(function() { const elm = $(this); elm.attr('href', elm.attr('data-href-template').replace('__fk__', value)); + elm.removeAttr('aria-disabled'); }); } else { siblings.removeAttr('href'); + siblings.attr('aria-disabled', true); } } diff --git a/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html b/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html index 6c285ea044..805f48b947 100644 --- a/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html +++ b/django/contrib/admin/templates/admin/widgets/related_widget_wrapper.html @@ -9,7 +9,7 @@ data-href-template="{{ change_related_template_url }}?{{ url_params }}" data-popup="yes" title="{% blocktranslate %}Change selected {{ model }}{% endblocktranslate %}"> - {% translate 'Change' %} + {% endif %} {% if can_add_related %} @@ -17,7 +17,7 @@ data-popup="yes" href="{{ add_related_url }}?{{ url_params }}" title="{% blocktranslate %}Add another {{ model }}{% endblocktranslate %}"> - {% translate 'Add' %} + {% endif %} {% if can_delete_related %} @@ -25,14 +25,14 @@ data-href-template="{{ delete_related_template_url }}?{{ url_params }}" data-popup="yes" title="{% blocktranslate %}Delete selected {{ model }}{% endblocktranslate %}"> - {% translate 'Delete' %} + {% endif %} {% if can_view_related %} - {% translate 'View' %} + {% endif %} {% endif %} -- cgit v1.3