1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
|
from datetime import UTC, date, datetime
from operator import attrgetter
import time_machine
from django.test import SimpleTestCase, TestCase
from django.urls import reverse
from djangoproject.tests import ReleaseMixin
from .models import (
Attachment,
Milestone,
Revision,
Ticket,
TicketChange,
TicketCustom,
Version,
Wiki,
)
from .testutils import TracDBCreateDatabaseMixin
from .tractime import (
datetime_to_timestamp,
dayrange,
time_property,
timestamp_to_datetime,
)
class TestModels(TestCase):
def test_router(self):
self.assertEqual(Revision.objects.db, "trac")
class TicketTestCase(TracDBCreateDatabaseMixin, ReleaseMixin, TestCase):
databases = {"default", "trac"}
def _create_ticket(self, custom=None, **kwargs):
"""
A factory to create a Ticket, with optional TicketCustom instances attached.
"""
if custom is None:
custom = {}
if "time" in kwargs:
assert "_time" not in kwargs
kwargs["_time"] = datetime_to_timestamp(kwargs.pop("time"))
ticket = Ticket.objects.create(**kwargs)
TicketCustom.objects.bulk_create(
[
TicketCustom(ticket=ticket, name=name, value=value)
for name, value in custom.items()
]
)
return ticket
def assertTicketsEqual(
self, queryset, expected, transform=attrgetter("summary"), ordered=False
):
"""
A wrapper around assertQuerysetEqual with some useful defaults
"""
self.assertQuerySetEqual(
queryset, expected, transform=transform, ordered=ordered
)
def test_ticket_table_exist_in_testdb(self):
self._create_ticket(summary="test", custom={"x": "y"})
self.assertTicketsEqual(Ticket.objects.all(), ["test"])
self.assertQuerySetEqual(
TicketCustom.objects.all(),
[("x", "y")],
transform=attrgetter("name", "value"),
ordered=False,
)
def test_with_custom(self):
self._create_ticket(summary="test1", custom={"x": "A", "y": "B"})
self._create_ticket(summary="test2", custom={"z": "C"})
self.assertQuerySetEqual(
Ticket.objects.with_custom().order_by("summary"),
[
("test1", {"x": "A", "y": "B"}),
("test2", {"z": "C"}),
],
transform=attrgetter("summary", "custom"),
)
def test_with_custom_lookup(self):
self._create_ticket(summary="test", custom={"x": "A", "y": "B"})
self.assertTicketsEqual(
Ticket.objects.with_custom().filter(custom__x="A"),
["test"],
)
def test_with_custom_lookup_multiple(self):
self._create_ticket(summary="test1", custom={"x": "A", "y": "A"})
self._create_ticket(summary="test2", custom={"x": "A", "y": "B"})
self._create_ticket(summary="test3", custom={"x": "B", "y": "A"})
self.assertTicketsEqual(
Ticket.objects.with_custom().filter(custom__x="A", custom__y="A"),
["test1"],
)
def test_from_querystring_model_field(self):
self._create_ticket(summary="test1", severity="high")
self._create_ticket(summary="test2", severity="low")
self.assertTicketsEqual(
Ticket.objects.from_querystring("severity=high"),
["test1"],
)
def test_from_querystring_model_field_multiple(self):
self._create_ticket(summary="test1", severity="high", resolution="new")
self._create_ticket(summary="test2", severity="high", resolution="fixed")
self._create_ticket(summary="test3", severity="low", resolution="new")
self._create_ticket(summary="test4", severity="low", resolution="fixed")
self.assertTicketsEqual(
Ticket.objects.from_querystring("severity=high&resolution=new"),
["test1"],
)
def test_from_querystring_model_field_negative(self):
self._create_ticket(summary="test1", severity="high")
self._create_ticket(summary="test2", severity="low")
self.assertTicketsEqual(
Ticket.objects.from_querystring("severity=!high"),
["test2"],
)
def test_from_querystring_model_field_negative_multiple(self):
self._create_ticket(summary="test1", severity="high", resolution="new")
self._create_ticket(summary="test2", severity="high", resolution="fixed")
self._create_ticket(summary="test3", severity="low", resolution="new")
self._create_ticket(summary="test4", severity="low", resolution="fixed")
self.assertTicketsEqual(
Ticket.objects.from_querystring("severity=!low&resolution=!fixed"),
["test1"],
)
def test_from_querystring_custom_field(self):
self._create_ticket(summary="test1", custom={"stage": "unreviewed"})
self._create_ticket(summary="test2", custom={"stage": "reviewed"})
self.assertTicketsEqual(
Ticket.objects.from_querystring("stage=reviewed"),
["test2"],
)
def test_from_querystring_custom_field_negative(self):
self._create_ticket(summary="test1", custom={"stage": "unreviewed"})
self._create_ticket(summary="test2", custom={"stage": "reviewed"})
self.assertTicketsEqual(
Ticket.objects.from_querystring("stage=!reviewed"),
["test1"],
)
def test_from_querystring_model_and_custom_field_together(self):
self._create_ticket(
summary="test1", severity="high", custom={"stage": "unreviewed"}
)
self._create_ticket(
summary="test2", severity="high", custom={"stage": "reviewed"}
)
self._create_ticket(
summary="test3", severity="low", custom={"stage": "unreviewed"}
)
self._create_ticket(
summary="test4", severity="low", custom={"stage": "reviewed"}
)
self.assertTicketsEqual(
Ticket.objects.from_querystring("severity=high&stage=unreviewed"),
["test1"],
)
@time_machine.travel("2024-10-24T14:30:00+00:00")
def test_from_querystring_time_today_same_day(self):
self._create_ticket(
summary="test",
time=datetime.fromisoformat("2024-10-24T10:30:00+00:00"),
)
self.assertTicketsEqual(
Ticket.objects.from_querystring("time=today.."), ["test"]
)
@time_machine.travel("2024-10-24T14:30:00+00:00")
def test_from_querystring_time_today_previous_day_less_than_24h(self):
self._create_ticket(
summary="test",
# previous day, but still within 24h
time=datetime.fromisoformat("2024-10-23T20:30:00+00:00"),
)
self.assertTicketsEqual(Ticket.objects.from_querystring("time=today.."), [])
@time_machine.travel("2024-10-24T14:30:00+00:00")
def test_from_querystring_time_today_previous_day_more_than_24h(self):
self._create_ticket(
summary="test",
# previous day, more than 24h ago
time=datetime.fromisoformat("2024-10-23T10:30:00+00:00"),
)
self.assertTicketsEqual(Ticket.objects.from_querystring("time=today.."), [])
@time_machine.travel("2024-10-24T14:30:00+00:00")
def test_from_querystring_time_thisweek(self):
self._create_ticket(
summary="test",
time=datetime.fromisoformat("2024-10-21T10:30:00+00:00"),
)
self._create_ticket(
summary="too old",
time=datetime.fromisoformat("2024-10-15T10:30:00+00:00"),
)
self.assertTicketsEqual(
Ticket.objects.from_querystring("time=thisweek.."), ["test"]
)
def test_from_querystring_invalid_time(self):
with self.assertRaises(ValueError):
Ticket.objects.from_querystring("time=2024-10-24..")
def test_api_ticket_404(self):
no_ticket_url = reverse("api_ticket", args=[30000])
response = self.client.get(no_ticket_url)
self.assertEqual(response.status_code, 404)
def test_api_ticket_405(self):
ticket = self._create_ticket(summary="test")
ticket_url = reverse("api_ticket", args=[ticket.id])
post_response = self.client.post(ticket_url, {})
delete_response = self.client.delete(ticket_url)
self.assertEqual(post_response.status_code, 405)
self.assertEqual(delete_response.status_code, 405)
def test_api_ticket_200(self):
ticket = self._create_ticket(
reporter="reporter@email.com",
type="Bug",
summary="test summary",
description="test description",
severity="Normal",
resolution="fixed",
status="assigned",
custom={
"stage": "Accepted",
"has_patch": "1",
"needs_better_patch": "0",
"needs_tests": "0",
},
)
with self.assertNumQueries(1, using="trac"):
response = self.client.get(reverse("api_ticket", args=[ticket.id]))
self.assertEqual(response.status_code, 200)
self.assertJSONEqual(
response.content,
{
"id": ticket.id,
"type": "Bug",
"summary": "test summary",
"description": "test description",
"severity": "Normal",
"status": "assigned",
"resolution": "fixed",
"custom": {
"stage": "Accepted",
"has_patch": "1",
"needs_better_patch": "0",
"needs_tests": "0",
},
},
)
class TracTimeTestCase(SimpleTestCase):
def test_datetime_to_timestamp(self):
testdata = [
(datetime(1970, 1, 1, microsecond=1, tzinfo=UTC), 1),
(datetime(1970, 1, 1, 0, 0, 1, tzinfo=UTC), 1_000_000),
(datetime(1970, 1, 2, tzinfo=UTC), 24 * 3600 * 1_000_000),
]
for dt, expected in testdata:
with self.subTest(dt=dt):
self.assertEqual(datetime_to_timestamp(dt), expected)
def test_timestamp_to_datetime(self):
testdata = [
(1, datetime(1970, 1, 1, microsecond=1, tzinfo=UTC)),
(1_000_000, datetime(1970, 1, 1, second=1, tzinfo=UTC)),
(24 * 3600 * 1_000_000, datetime(1970, 1, 2, tzinfo=UTC)),
]
for ts, expected in testdata:
with self.subTest(ts=ts):
self.assertEqual(timestamp_to_datetime(ts), expected)
def test_time_property(self):
class T:
timestamp = 1
prop = time_property("timestamp")
self.assertEqual(T().prop.date(), date(1970, 1, 1))
def test_dayrange_error_negative_day(self):
with self.assertRaises(ValueError):
dayrange(date.today(), -1)
def test_dayrange_error_zero_day(self):
with self.assertRaises(ValueError):
dayrange(date.today(), 0)
def test_dayrange_error_datetime(self):
with self.assertRaises(TypeError):
dayrange(datetime.now(), 1)
def test_dayrange_1_day(self):
offset = 6 * 3600 * 1_000_000 # offset between utc and chicago
self.assertEqual(
dayrange(date(1970, 1, 1), days=1),
(offset, offset + 24 * 3600 * 1_000_000 - 1),
)
class TimePropertyTest(SimpleTestCase):
def test_time_property_on_all_fields(self):
for model_class, field_name, property_name in [
(Ticket, "_time", "time"),
(Ticket, "_changetime", "changetime"),
(TicketChange, "_time", "time"),
(Version, "_time", "time"),
(Milestone, "_due", "due"),
(Milestone, "_completed", "completed"),
(Revision, "_time", "time"),
(Wiki, "_time", "time"),
(Attachment, "_time", "time"),
]:
with self.subTest(model=model_class, field=field_name):
obj = model_class(**{field_name: 1_000_000})
self.assertEqual(
getattr(obj, property_name),
datetime(1970, 1, 1, 0, 0, 1, tzinfo=UTC),
)
|