diff options
| author | Jacob Walls <jacobtylerwalls@gmail.com> | 2025-01-02 20:41:29 -0500 |
|---|---|---|
| committer | Sarah Boyce <42296566+sarahboyce@users.noreply.github.com> | 2025-01-06 09:33:27 +0100 |
| commit | 46b3e7dd8cc1792a40bb8b4d0c267f3d1ceef68c (patch) | |
| tree | fe933593e9b6242b766ff7ba185b19d597403c2a /tests | |
| parent | 51df0dff3c4f28016185a9e876ee5b3420712f99 (diff) | |
Fixed #36048 -- Preferred ValueError to NotSupportedError for composite pk sanity checks.
These checks are not backend-dependent.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/composite_pk/test_aggregate.py | 3 | ||||
| -rw-r--r-- | tests/foreign_object/test_tuple_lookups.py | 13 |
2 files changed, 7 insertions, 9 deletions
diff --git a/tests/composite_pk/test_aggregate.py b/tests/composite_pk/test_aggregate.py index b5474c5218..7b40bffe9a 100644 --- a/tests/composite_pk/test_aggregate.py +++ b/tests/composite_pk/test_aggregate.py @@ -1,4 +1,3 @@ -from django.db import NotSupportedError from django.db.models import Count, Q from django.test import TestCase @@ -82,7 +81,7 @@ class CompositePKAggregateTests(TestCase): def test_count_distinct_not_supported(self): with self.assertRaisesMessage( - NotSupportedError, "COUNT(DISTINCT) doesn't support composite primary keys" + ValueError, "COUNT(DISTINCT) doesn't support composite primary keys" ): self.assertIsNone( User.objects.annotate(comments__count=Count("comments", distinct=True)) diff --git a/tests/foreign_object/test_tuple_lookups.py b/tests/foreign_object/test_tuple_lookups.py index 797fea1c8a..42717c4f11 100644 --- a/tests/foreign_object/test_tuple_lookups.py +++ b/tests/foreign_object/test_tuple_lookups.py @@ -1,6 +1,5 @@ import itertools -from django.db import NotSupportedError from django.db.models import F from django.db.models.fields.tuple_lookups import ( TupleExact, @@ -65,7 +64,7 @@ class TupleLookupsTests(TestCase): def test_exact_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'exact' doesn't support multi-column subqueries." + ValueError, "'exact' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=self.customer_1.id)[:1] self.assertSequenceEqual( @@ -239,7 +238,7 @@ class TupleLookupsTests(TestCase): def test_lt_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'lt' doesn't support multi-column subqueries." + ValueError, "'lt' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=self.customer_1.id)[:1] self.assertSequenceEqual( @@ -287,7 +286,7 @@ class TupleLookupsTests(TestCase): def test_lte_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'lte' doesn't support multi-column subqueries." + ValueError, "'lte' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=self.customer_1.id)[:1] self.assertSequenceEqual( @@ -327,7 +326,7 @@ class TupleLookupsTests(TestCase): def test_gt_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'gt' doesn't support multi-column subqueries." + ValueError, "'gt' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=self.customer_1.id)[:1] self.assertSequenceEqual( @@ -375,7 +374,7 @@ class TupleLookupsTests(TestCase): def test_gte_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'gte' doesn't support multi-column subqueries." + ValueError, "'gte' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=self.customer_1.id)[:1] self.assertSequenceEqual( @@ -419,7 +418,7 @@ class TupleLookupsTests(TestCase): def test_isnull_subquery(self): with self.assertRaisesMessage( - NotSupportedError, "'isnull' doesn't support multi-column subqueries." + ValueError, "'isnull' doesn't support multi-column subqueries." ): subquery = Customer.objects.filter(id=0)[:1] self.assertSequenceEqual( |
