diff options
| author | Tim Graham <timograham@gmail.com> | 2016-06-28 11:21:26 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-06-28 11:21:26 -0400 |
| commit | c9ae09addffb839403312131d4251e9d8b454508 (patch) | |
| tree | 74913fbe2e90d88e094f8594947ebf313ec5f12f /tests/validation | |
| parent | c1b6f554e405fe733e8d80f7e3d77c277810e707 (diff) | |
Replaced use of TestCase.fail() with assertRaises().
Also removed try/except/fail antipattern that hides exceptions.
Diffstat (limited to 'tests/validation')
| -rw-r--r-- | tests/validation/test_unique.py | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/tests/validation/test_unique.py b/tests/validation/test_unique.py index 8b79913d19..0780b9ec43 100644 --- a/tests/validation/test_unique.py +++ b/tests/validation/test_unique.py @@ -144,27 +144,22 @@ class PerformUniqueChecksTest(TestCase): self.assertEqual(cm.exception.message_dict, {'posted': ['This field cannot be null.']}) def test_unique_for_date_with_nullable_date(self): + """ + unique_for_date/year/month checks shouldn't trigger when the + associated DateField is None. + """ FlexibleDatePost.objects.create( title="Django 1.0 is released", slug="Django 1.0", subtitle="Finally", posted=datetime.date(2008, 9, 3), ) p = FlexibleDatePost(title="Django 1.0 is released") - try: - p.full_clean() - except ValidationError: - self.fail("unique_for_date checks shouldn't trigger when the associated DateField is None.") + p.full_clean() p = FlexibleDatePost(slug="Django 1.0") - try: - p.full_clean() - except ValidationError: - self.fail("unique_for_year checks shouldn't trigger when the associated DateField is None.") + p.full_clean() p = FlexibleDatePost(subtitle="Finally") - try: - p.full_clean() - except ValidationError: - self.fail("unique_for_month checks shouldn't trigger when the associated DateField is None.") + p.full_clean() def test_unique_errors(self): UniqueErrorsModel.objects.create(name='Some Name', no=10) |
