summaryrefslogtreecommitdiff
path: root/tests/utils_tests/test_http.py
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2016-03-04 23:33:35 +0100
committerClaude Paroz <claude@2xlibre.net>2016-03-04 23:33:35 +0100
commit552f03869ea7f3072b3fa19ffb6cb2d957fd8447 (patch)
tree682fddbf235af897d93a1814915b5c588dac88e5 /tests/utils_tests/test_http.py
parentada7a4aefb9bec4c34667b511022be6057102f98 (diff)
Added safety to URL decoding in is_safe_url() on Python 2
The errors='replace' parameter to force_text altered the URL before checking it, which wasn't considered sane. Refs 24fc935218 and ada7a4aef.
Diffstat (limited to 'tests/utils_tests/test_http.py')
-rw-r--r--tests/utils_tests/test_http.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/utils_tests/test_http.py b/tests/utils_tests/test_http.py
index 3a1bbbf66e..8f93c472a7 100644
--- a/tests/utils_tests/test_http.py
+++ b/tests/utils_tests/test_http.py
@@ -124,7 +124,7 @@ class TestUtilsHttp(unittest.TestCase):
)
self.assertFalse(http.is_safe_url(b'\x08//example.com', host='testserver'))
self.assertTrue(http.is_safe_url('àview/'.encode('utf-8'), host='testserver'))
- self.assertTrue(http.is_safe_url('àview'.encode('latin-1'), host='testserver'))
+ self.assertFalse(http.is_safe_url('àview'.encode('latin-1'), host='testserver'))
# Valid basic auth credentials are allowed.
self.assertTrue(http.is_safe_url(r'http://user:pass@testserver/', host='user:pass@testserver'))