summaryrefslogtreecommitdiff
path: root/tests/urlpatterns
diff options
context:
space:
mode:
authorkundan223 <kundan0707y@gmail.com>2025-12-14 13:02:25 +0530
committernessita <124304+nessita@users.noreply.github.com>2025-12-26 09:24:58 -0300
commit7bf3ac3ee255bcfe329e3203c7a2555b1275d506 (patch)
tree0dfb5565a013200d26c77ba46b902ee141669310 /tests/urlpatterns
parent8e4b531111ddd3256c45eee601947e475651e8e7 (diff)
Fixed #36796 -- Handled lazy routes correctly in RoutePattern.match().
Coerce lazy route values to `str` at match time to support prefix and endpoint matching when using `gettext_lazy()` route paths. Regression in f920937c8a63df6bea220e4386f59cdb45b2e355. Thanks to Andrea Angelini for the report, and to Jake Howard and Jacob Walls for reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Diffstat (limited to 'tests/urlpatterns')
-rw-r--r--tests/urlpatterns/lazy_path_urls.py9
-rw-r--r--tests/urlpatterns/test_resolvers.py31
2 files changed, 40 insertions, 0 deletions
diff --git a/tests/urlpatterns/lazy_path_urls.py b/tests/urlpatterns/lazy_path_urls.py
new file mode 100644
index 0000000000..01fcfcb3ae
--- /dev/null
+++ b/tests/urlpatterns/lazy_path_urls.py
@@ -0,0 +1,9 @@
+from django.urls import include, path
+from django.utils.translation import gettext_lazy as _
+
+from . import views
+
+urlpatterns = [
+ path(_("included_urls/"), include("urlpatterns.included_urls")),
+ path(_("lazy/<slug:slug>/"), views.empty_view, name="lazy"),
+]
diff --git a/tests/urlpatterns/test_resolvers.py b/tests/urlpatterns/test_resolvers.py
index 99b2f9154c..f61456a921 100644
--- a/tests/urlpatterns/test_resolvers.py
+++ b/tests/urlpatterns/test_resolvers.py
@@ -3,6 +3,8 @@ from django.test.utils import override_settings
from django.urls.resolvers import RegexPattern, RoutePattern, get_resolver
from django.utils.translation import gettext_lazy as _
+from . import views
+
class RegexPatternTests(SimpleTestCase):
def test_str(self):
@@ -19,6 +21,21 @@ class RoutePatternTests(SimpleTestCase):
self.assertEqual(len(RoutePattern("translated/<int:foo>").converters), 1)
self.assertEqual(len(RoutePattern(_("translated/<int:foo>")).converters), 1)
+ def test_match_lazy_route_without_converters(self):
+ pattern = RoutePattern(_("test/"))
+ result = pattern.match("test/child/")
+ self.assertEqual(result, ("child/", (), {}))
+
+ def test_match_lazy_route_endpoint(self):
+ pattern = RoutePattern(_("test/"), is_endpoint=True)
+ result = pattern.match("test/")
+ self.assertEqual(result, ("", (), {}))
+
+ def test_match_lazy_route_with_converters(self):
+ pattern = RoutePattern(_("test/<int:pk>/"))
+ result = pattern.match("test/123/child/")
+ self.assertEqual(result, ("child/", (), {"pk": 123}))
+
class ResolverCacheTests(SimpleTestCase):
@override_settings(ROOT_URLCONF="urlpatterns.path_urls")
@@ -27,3 +44,17 @@ class ResolverCacheTests(SimpleTestCase):
# settings.ROOT_URLCONF is the same cached object.
self.assertIs(get_resolver(), get_resolver("urlpatterns.path_urls"))
self.assertIsNot(get_resolver(), get_resolver("urlpatterns.path_dynamic_urls"))
+
+
+class ResolverLazyIncludeTests(SimpleTestCase):
+
+ def test_lazy_route_resolves(self):
+ resolver = get_resolver("urlpatterns.lazy_path_urls")
+ for url_path, name in [
+ ("/lazy/test-me/", "lazy"),
+ ("/included_urls/extra/test/", "inner-extra"),
+ ]:
+ with self.subTest(name=name):
+ match = resolver.resolve(url_path)
+ self.assertEqual(match.func, views.empty_view)
+ self.assertEqual(match.url_name, name)