summaryrefslogtreecommitdiff
path: root/tests/test_client_regress
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2023-11-23 00:09:08 -0500
committerGitHub <noreply@github.com>2023-11-23 06:09:08 +0100
commite76cc93b0168fa3abbafb9af1ab4535814b751f0 (patch)
treeda85f315a2ed4be643b026ff07b6c0f3cbaa68b5 /tests/test_client_regress
parentaceee39d44994df20d13104e55ae61845d7a1e95 (diff)
Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
Regression in f387d024fc75569d2a4a338bfda76cc2f328f627. Just like `OrderByList` the `ExpressionList` expression used to wrap `Window.partition_by` must implement `get_group_by_cols` to ensure the necessary grouping when mixing window expressions with aggregate annotations is performed against the partition members and not the partition expression itself. This is necessary because while `partition_by` is implemented as a source expression of `Window` it's actually a fragment of the WINDOW expression at the SQL level and thus it should result in a group by its members and not the sum of them. Thanks ElRoberto538 for the report.
Diffstat (limited to 'tests/test_client_regress')
0 files changed, 0 insertions, 0 deletions