summaryrefslogtreecommitdiff
path: root/tests/model_forms
diff options
context:
space:
mode:
authorJon Dufresne <jon.dufresne@gmail.com>2017-05-27 16:08:46 -0700
committerTim Graham <timograham@gmail.com>2017-05-27 19:08:46 -0400
commit21046e77734278cea871dce922220bf29aa5b7b4 (patch)
treee0820850a3d058c35307916da793668f7e5c48b3 /tests/model_forms
parent2a5708a304cf337dbf556e2bd87a930079f8f766 (diff)
Fixed #28249 -- Removed unnecessary dict.keys() calls.
iter(dict) is equivalent to iter(dict.keys()).
Diffstat (limited to 'tests/model_forms')
-rw-r--r--tests/model_forms/tests.py18
1 files changed, 9 insertions, 9 deletions
diff --git a/tests/model_forms/tests.py b/tests/model_forms/tests.py
index c85eb2a6fa..6520e54d06 100644
--- a/tests/model_forms/tests.py
+++ b/tests/model_forms/tests.py
@@ -2783,7 +2783,7 @@ class ModelFormInheritanceTests(SimpleTestCase):
model = Writer
fields = '__all__'
- self.assertEqual(list(ModelForm().fields.keys()), ['name', 'age'])
+ self.assertEqual(list(ModelForm().fields), ['name', 'age'])
def test_field_removal(self):
class ModelForm(forms.ModelForm):
@@ -2800,13 +2800,13 @@ class ModelFormInheritanceTests(SimpleTestCase):
class Form2(forms.Form):
foo = forms.IntegerField()
- self.assertEqual(list(ModelForm().fields.keys()), ['name'])
- self.assertEqual(list(type('NewForm', (Mixin, Form), {})().fields.keys()), [])
- self.assertEqual(list(type('NewForm', (Form2, Mixin, Form), {})().fields.keys()), ['foo'])
- self.assertEqual(list(type('NewForm', (Mixin, ModelForm, Form), {})().fields.keys()), ['name'])
- self.assertEqual(list(type('NewForm', (ModelForm, Mixin, Form), {})().fields.keys()), ['name'])
- self.assertEqual(list(type('NewForm', (ModelForm, Form, Mixin), {})().fields.keys()), ['name', 'age'])
- self.assertEqual(list(type('NewForm', (ModelForm, Form), {'age': None})().fields.keys()), ['name'])
+ self.assertEqual(list(ModelForm().fields), ['name'])
+ self.assertEqual(list(type('NewForm', (Mixin, Form), {})().fields), [])
+ self.assertEqual(list(type('NewForm', (Form2, Mixin, Form), {})().fields), ['foo'])
+ self.assertEqual(list(type('NewForm', (Mixin, ModelForm, Form), {})().fields), ['name'])
+ self.assertEqual(list(type('NewForm', (ModelForm, Mixin, Form), {})().fields), ['name'])
+ self.assertEqual(list(type('NewForm', (ModelForm, Form, Mixin), {})().fields), ['name', 'age'])
+ self.assertEqual(list(type('NewForm', (ModelForm, Form), {'age': None})().fields), ['name'])
def test_field_removal_name_clashes(self):
"""
@@ -2974,7 +2974,7 @@ class FormFieldCallbackTests(SimpleTestCase):
class InheritedForm(NewForm):
pass
- for name in NewForm.base_fields.keys():
+ for name in NewForm.base_fields:
self.assertEqual(
type(InheritedForm.base_fields[name].widget),
type(NewForm.base_fields[name].widget)