diff options
| author | Matthias Kestenholz <mk@feinheit.ch> | 2025-06-15 16:38:10 +0200 |
|---|---|---|
| committer | nessita <124304+nessita@users.noreply.github.com> | 2025-08-05 11:35:04 -0300 |
| commit | 0a262c8407a2f4e4971118ca435c6931c40b70ae (patch) | |
| tree | b922a295cb776eef0734211e95b7aa273865fb2d /tests/gis_tests | |
| parent | 2013092b693be0ebdf36f41dc61615a2de1bbe31 (diff) | |
Fixed #36537 -- Ensured unique HTML IDs for geometry widget option scripts in the admin.
This work amends the code from f2f6046c0f92ff1faed057da0711ac478eef439c
where multiple geometry widgets rendered `<script>` elements in the
admin with the same HTML `id`, resulting in invalid HTML and fragile
JavaScript selectors. Refs #25706.
This change uses the widget's textarea ID to generate a unique `id` for
each JSON options `<script>`, ensuring valid and robust markup.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Diffstat (limited to 'tests/gis_tests')
| -rw-r--r-- | tests/gis_tests/test_geoforms.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/gis_tests/test_geoforms.py b/tests/gis_tests/test_geoforms.py index 2a1f585906..753505fc68 100644 --- a/tests/gis_tests/test_geoforms.py +++ b/tests/gis_tests/test_geoforms.py @@ -214,7 +214,7 @@ class GeometryFieldTest(SimpleTestCase): "id": "id_p", "geom_name": "Point", } - expected = json_script(attrs, "mapwidget-options") + expected = json_script(attrs, "id_p_mapwidget_options") self.assertInHTML(expected, rendered) @@ -305,7 +305,7 @@ class SpecializedFieldTest(SimpleTestCase): "id": map_field.id_for_label, "geom_name": geom_name, } - expected = json_script(attrs, "mapwidget-options") + expected = json_script(attrs, f"{map_field.id_for_label}_mapwidget_options") self.assertInHTML(expected, rendered) self.assertIn("gis/js/OLMapWidget.js", str(form_instance.media)) @@ -475,7 +475,7 @@ class OSMWidgetTest(SimpleTestCase): "id": "id_p", "geom_name": "Point", } - expected = json_script(attrs, "mapwidget-options") + expected = json_script(attrs, "id_p_mapwidget_options") self.assertInHTML(expected, rendered) |