diff options
| author | Matthew Somerville <matthew-github@dracos.co.uk> | 2015-01-28 21:43:23 +0000 |
|---|---|---|
| committer | Claude Paroz <claude@2xlibre.net> | 2015-02-03 18:18:12 +0100 |
| commit | 250aa7c39b0025ef3ae508884fda8d6e43c9518f (patch) | |
| tree | 8565f3ebc9bc7e59f6e7743e948919e6e4428589 /tests/generic_inline_admin | |
| parent | cd4282816db9164791cd0ac97a3dc329ad92c522 (diff) | |
Fixed #24240 -- Allowed GZipping a Unicode StreamingHttpResponse
make_bytes() assumed that if the Content-Encoding header is set, then
everything had already been dealt with bytes-wise, but in a streaming
situation this was not necessarily the case.
make_bytes() is only called when necessary when working with a
StreamingHttpResponse iterable, but by that point the middleware has
added the Content-Encoding header and thus make_bytes() tried to call
bytes(value) (and dies). If it had been a normal HttpResponse,
make_bytes() would have been called when the content was set, well
before the middleware set the Content-Encoding header.
This commit removes the special casing when Content-Encoding is set,
allowing unicode strings to be encoded during the iteration before they
are e.g. gzipped. This behaviour was added a long time ago for #4969 and
it doesn't appear to be necessary any more, as everything is correctly
made into bytes at the appropriate places.
Two new tests, to show that supplying non-ASCII characters to a
StreamingHttpResponse works fine normally, and when passed through the
GZip middleware (the latter dies without the change to make_bytes()).
Removes the test with a nonsense Content-Encoding and Unicode input - if
this were to happen, it can still be encoded as bytes fine.
Diffstat (limited to 'tests/generic_inline_admin')
0 files changed, 0 insertions, 0 deletions
