summaryrefslogtreecommitdiff
path: root/tests/file_storage/test_generate_filename.py
diff options
context:
space:
mode:
authorFlorian Apolloner <florian@apolloner.eu>2021-12-17 21:07:50 +0100
committerCarlton Gibson <carlton.gibson@noumenal.es>2022-01-04 10:19:49 +0100
commit8d2f7cff76200cbd2337b2cf1707e383eb1fb54b (patch)
treef3f00f41e92d751a91f61b164e4951e284d920d5 /tests/file_storage/test_generate_filename.py
parentc7fe895bca06daf12cc1670b56eaf72a1ef27a16 (diff)
[3.2.x] Fixed CVE-2021-45452 -- Fixed potential path traversal in storage subsystem.
Thanks to Dennis Brinkrolf for the report.
Diffstat (limited to 'tests/file_storage/test_generate_filename.py')
-rw-r--r--tests/file_storage/test_generate_filename.py19
1 files changed, 13 insertions, 6 deletions
diff --git a/tests/file_storage/test_generate_filename.py b/tests/file_storage/test_generate_filename.py
index 66551c495b..78fd064732 100644
--- a/tests/file_storage/test_generate_filename.py
+++ b/tests/file_storage/test_generate_filename.py
@@ -53,13 +53,20 @@ class GenerateFilenameStorageTests(SimpleTestCase):
s.generate_filename(file_name)
def test_storage_dangerous_paths_dir_name(self):
- file_name = '/tmp/../path'
+ candidates = [
+ ('tmp/../path', 'tmp/..'),
+ ('tmp\\..\\path', 'tmp/..'),
+ ('/tmp/../path', '/tmp/..'),
+ ('\\tmp\\..\\path', '/tmp/..'),
+ ]
s = FileSystemStorage()
- msg = "Detected path traversal attempt in '/tmp/..'"
- with self.assertRaisesMessage(SuspiciousFileOperation, msg):
- s.get_available_name(file_name)
- with self.assertRaisesMessage(SuspiciousFileOperation, msg):
- s.generate_filename(file_name)
+ for file_name, path in candidates:
+ msg = "Detected path traversal attempt in '%s'" % path
+ with self.subTest(file_name=file_name):
+ with self.assertRaisesMessage(SuspiciousFileOperation, msg):
+ s.get_available_name(file_name)
+ with self.assertRaisesMessage(SuspiciousFileOperation, msg):
+ s.generate_filename(file_name)
def test_filefield_dangerous_filename(self):
candidates = [