diff options
| author | can <cansarigol@derinbilgi.com.tr> | 2019-07-05 15:15:41 +0300 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-07-08 14:57:56 +0200 |
| commit | febe136d4c3310ec8901abecca3ea5ba2be3952c (patch) | |
| tree | 4eeae36c3ae832a90f8a4721b2de54ea555a8478 /tests/check_framework | |
| parent | 8233144ca0c93b589b61a2ad0fb7c851f3356a3b (diff) | |
Fixed #30397 -- Added app_label/class interpolation for names of indexes and constraints.
Diffstat (limited to 'tests/check_framework')
| -rw-r--r-- | tests/check_framework/test_model_checks.py | 66 |
1 files changed, 66 insertions, 0 deletions
diff --git a/tests/check_framework/test_model_checks.py b/tests/check_framework/test_model_checks.py index 0cbc0aff44..79177e38f7 100644 --- a/tests/check_framework/test_model_checks.py +++ b/tests/check_framework/test_model_checks.py @@ -131,6 +131,22 @@ class IndexNameTests(SimpleTestCase): ), ]) + def test_no_collision_abstract_model_interpolation(self): + class AbstractModel(models.Model): + name = models.CharField(max_length=20) + + class Meta: + indexes = [models.Index(fields=['name'], name='%(app_label)s_%(class)s_foo')] + abstract = True + + class Model1(AbstractModel): + pass + + class Model2(AbstractModel): + pass + + self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) + @modify_settings(INSTALLED_APPS={'append': 'basic'}) @isolate_apps('basic', 'check_framework', kwarg_name='apps') def test_collision_across_apps(self, apps): @@ -154,6 +170,23 @@ class IndexNameTests(SimpleTestCase): ), ]) + @modify_settings(INSTALLED_APPS={'append': 'basic'}) + @isolate_apps('basic', 'check_framework', kwarg_name='apps') + def test_no_collision_across_apps_interpolation(self, apps): + index = models.Index(fields=['id'], name='%(app_label)s_%(class)s_foo') + + class Model1(models.Model): + class Meta: + app_label = 'basic' + constraints = [index] + + class Model2(models.Model): + class Meta: + app_label = 'check_framework' + constraints = [index] + + self.assertEqual(checks.run_checks(app_configs=apps.get_app_configs()), []) + @isolate_apps('check_framework', attr_name='apps') @override_system_checks([checks.model_checks.check_all_models]) @@ -214,6 +247,22 @@ class ConstraintNameTests(TestCase): ), ]) + def test_no_collision_abstract_model_interpolation(self): + class AbstractModel(models.Model): + class Meta: + constraints = [ + models.CheckConstraint(check=models.Q(id__gt=0), name='%(app_label)s_%(class)s_foo'), + ] + abstract = True + + class Model1(AbstractModel): + pass + + class Model2(AbstractModel): + pass + + self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) + @modify_settings(INSTALLED_APPS={'append': 'basic'}) @isolate_apps('basic', 'check_framework', kwarg_name='apps') def test_collision_across_apps(self, apps): @@ -236,3 +285,20 @@ class ConstraintNameTests(TestCase): id='models.E032', ), ]) + + @modify_settings(INSTALLED_APPS={'append': 'basic'}) + @isolate_apps('basic', 'check_framework', kwarg_name='apps') + def test_no_collision_across_apps_interpolation(self, apps): + constraint = models.CheckConstraint(check=models.Q(id__gt=0), name='%(app_label)s_%(class)s_foo') + + class Model1(models.Model): + class Meta: + app_label = 'basic' + constraints = [constraint] + + class Model2(models.Model): + class Meta: + app_label = 'check_framework' + constraints = [constraint] + + self.assertEqual(checks.run_checks(app_configs=apps.get_app_configs()), []) |
