diff options
| author | Tim Graham <timograham@gmail.com> | 2025-08-19 15:08:43 -0400 |
|---|---|---|
| committer | Jacob Walls <jacobtylerwalls@gmail.com> | 2025-09-05 10:43:10 -0400 |
| commit | 2a636118dacdcda074c99ebd50311d64a8cca367 (patch) | |
| tree | f5b11c60f9fd598429d6ab60b35515a6c6d82256 /tests/check_framework | |
| parent | 0ddbe12ea99a2dc1b757dc2015ba8bb6bfd9d653 (diff) | |
Fixed #36564 -- Changed DEFAULT_AUTO_FIELD from AutoField to BigAutoField.
Diffstat (limited to 'tests/check_framework')
| -rw-r--r-- | tests/check_framework/apps.py | 10 | ||||
| -rw-r--r-- | tests/check_framework/test_model_checks.py | 135 |
2 files changed, 0 insertions, 145 deletions
diff --git a/tests/check_framework/apps.py b/tests/check_framework/apps.py deleted file mode 100644 index b78d603855..0000000000 --- a/tests/check_framework/apps.py +++ /dev/null @@ -1,10 +0,0 @@ -from django.apps import AppConfig - - -class CheckDefaultPKConfig(AppConfig): - name = "check_framework" - - -class CheckPKConfig(AppConfig): - name = "check_framework" - default_auto_field = "django.db.models.BigAutoField" diff --git a/tests/check_framework/test_model_checks.py b/tests/check_framework/test_model_checks.py index be504f9c2d..18553cd7cb 100644 --- a/tests/check_framework/test_model_checks.py +++ b/tests/check_framework/test_model_checks.py @@ -1,5 +1,3 @@ -from unittest import mock - from django.core import checks from django.core.checks import Error, Warning from django.db import models @@ -411,136 +409,3 @@ class ConstraintNameTests(TestCase): constraints = [constraint] self.assertEqual(checks.run_checks(app_configs=apps.get_app_configs()), []) - - -def mocked_is_overridden(self, setting): - # Force treating DEFAULT_AUTO_FIELD = 'django.db.models.AutoField' as a not - # overridden setting. - return ( - setting != "DEFAULT_AUTO_FIELD" - or self.DEFAULT_AUTO_FIELD != "django.db.models.AutoField" - ) - - -@mock.patch("django.conf.UserSettingsHolder.is_overridden", mocked_is_overridden) -@override_settings(DEFAULT_AUTO_FIELD="django.db.models.AutoField") -@isolate_apps("check_framework.apps.CheckDefaultPKConfig", attr_name="apps") -@override_system_checks([checks.model_checks.check_all_models]) -class ModelDefaultAutoFieldTests(SimpleTestCase): - msg = ( - "Auto-created primary key used when not defining a primary key type, " - "by default 'django.db.models.AutoField'." - ) - hint = ( - "Configure the DEFAULT_AUTO_FIELD setting or the " - "CheckDefaultPKConfig.default_auto_field attribute to point to a " - "subclass of AutoField, e.g. 'django.db.models.BigAutoField'." - ) - - def test_auto_created_pk(self): - class Model(models.Model): - pass - - self.assertEqual( - checks.run_checks(app_configs=self.apps.get_app_configs()), - [ - Warning(self.msg, hint=self.hint, obj=Model, id="models.W042"), - ], - ) - - def test_explicit_inherited_pk(self): - class Parent(models.Model): - id = models.AutoField(primary_key=True) - - class Child(Parent): - pass - - self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) - - def test_skipped_on_model_with_invalid_app_label(self): - class Model(models.Model): - class Meta: - app_label = "invalid_app_label" - - self.assertEqual(Model.check(), []) - - def test_skipped_on_abstract_model(self): - class Abstract(models.Model): - class Meta: - abstract = True - - # Call .check() because abstract models are not registered. - self.assertEqual(Abstract.check(), []) - - def test_explicit_inherited_parent_link(self): - class Parent(models.Model): - id = models.AutoField(primary_key=True) - - class Child(Parent): - parent_ptr = models.OneToOneField(Parent, models.CASCADE, parent_link=True) - - self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) - - def test_auto_created_inherited_pk(self): - class Parent(models.Model): - pass - - class Child(Parent): - pass - - self.assertEqual( - checks.run_checks(app_configs=self.apps.get_app_configs()), - [ - Warning(self.msg, hint=self.hint, obj=Parent, id="models.W042"), - ], - ) - - def test_auto_created_inherited_parent_link(self): - class Parent(models.Model): - pass - - class Child(Parent): - parent_ptr = models.OneToOneField(Parent, models.CASCADE, parent_link=True) - - self.assertEqual( - checks.run_checks(app_configs=self.apps.get_app_configs()), - [ - Warning(self.msg, hint=self.hint, obj=Parent, id="models.W042"), - ], - ) - - def test_auto_created_pk_inherited_abstract_parent(self): - class Parent(models.Model): - class Meta: - abstract = True - - class Child(Parent): - pass - - self.assertEqual( - checks.run_checks(app_configs=self.apps.get_app_configs()), - [ - Warning(self.msg, hint=self.hint, obj=Child, id="models.W042"), - ], - ) - - @override_settings(DEFAULT_AUTO_FIELD="django.db.models.BigAutoField") - def test_default_auto_field_setting(self): - class Model(models.Model): - pass - - self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) - - def test_explicit_pk(self): - class Model(models.Model): - id = models.BigAutoField(primary_key=True) - - self.assertEqual(checks.run_checks(app_configs=self.apps.get_app_configs()), []) - - @isolate_apps("check_framework.apps.CheckPKConfig", kwarg_name="apps") - def test_app_default_auto_field(self, apps): - class ModelWithPkViaAppConfig(models.Model): - class Meta: - app_label = "check_framework.apps.CheckPKConfig" - - self.assertEqual(checks.run_checks(app_configs=apps.get_app_configs()), []) |
