summaryrefslogtreecommitdiff
path: root/tests/cache
diff options
context:
space:
mode:
authorshanghui <shangdahao@gmail.com>2018-02-06 13:44:53 +0800
committerTim Graham <timograham@gmail.com>2018-02-06 09:42:05 -0500
commitd968788b57f41b7def88046d1178fd2932a32a4e (patch)
tree4deb03cc07e4525db103e8b26f6cc5726acf18da /tests/cache
parent272f685794de0b8dead220ee57b30e65c9aa097c (diff)
Fixed #28833 -- Prevented CacheMiddleware from caching responses with "Cache-Control: private".
Diffstat (limited to 'tests/cache')
-rw-r--r--tests/cache/tests.py11
1 files changed, 10 insertions, 1 deletions
diff --git a/tests/cache/tests.py b/tests/cache/tests.py
index 79c49edd7e..86f5bdce38 100644
--- a/tests/cache/tests.py
+++ b/tests/cache/tests.py
@@ -39,7 +39,7 @@ from django.utils import timezone, translation
from django.utils.cache import (
get_cache_key, learn_cache_key, patch_cache_control, patch_vary_headers,
)
-from django.views.decorators.cache import cache_page
+from django.views.decorators.cache import cache_control, cache_page
from .models import Poll, expensive_calculation
@@ -2163,6 +2163,15 @@ class CacheMiddlewareTest(SimpleTestCase):
response = other_with_prefix_view(request, '16')
self.assertEqual(response.content, b'Hello World 16')
+ def test_cached_control_private_not_cached(self):
+ """Responses with 'Cache-Control: private' are not cached."""
+ view_with_private_cache = cache_page(3)(cache_control(private=True)(hello_world_view))
+ request = self.factory.get('/view/')
+ response = view_with_private_cache(request, '1')
+ self.assertEqual(response.content, b'Hello World 1')
+ response = view_with_private_cache(request, '2')
+ self.assertEqual(response.content, b'Hello World 2')
+
def test_sensitive_cookie_not_cached(self):
"""
Django must prevent caching of responses that set a user-specific (and