diff options
| author | Carlton Gibson <carlton.gibson@noumenal.es> | 2019-06-13 10:57:29 +0200 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-07-01 07:48:04 +0200 |
| commit | 54d0f5e62f54c29a12dd96f44bacd810cbe03ac8 (patch) | |
| tree | c8ccf1b4aa9c140a56f61e844723f5ff89ae9b5c /docs/releases/2.2.3.txt | |
| parent | 30b3ee9d0b33bb440f9c73d1ce9e0e7303887a9f (diff) | |
Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set.
An HTTP request would not be redirected to HTTPS when the
SECURE_PROXY_SSL_HEADER and SECURE_SSL_REDIRECT settings were used if
the proxy connected to Django via HTTPS.
HttpRequest.scheme will now always trust the SECURE_PROXY_SSL_HEADER if
set, rather than falling back to the request scheme when the
SECURE_PROXY_SSL_HEADER did not have the secure value.
Thanks to Gavin Wahl for the report and initial patch suggestion, and
Shai Berger for review.
Diffstat (limited to 'docs/releases/2.2.3.txt')
| -rw-r--r-- | docs/releases/2.2.3.txt | 24 |
1 files changed, 22 insertions, 2 deletions
diff --git a/docs/releases/2.2.3.txt b/docs/releases/2.2.3.txt index 2bb8736192..1dd20d3bfd 100644 --- a/docs/releases/2.2.3.txt +++ b/docs/releases/2.2.3.txt @@ -4,8 +4,28 @@ Django 2.2.3 release notes *Expected July 1, 2019* -Django 2.2.3 fixes several bugs in 2.2.2. Also, the latest string translations -from Transifex are incorporated. +Django 2.2.3 fixes a security issue and several bugs in 2.2.2. Also, the latest +string translations from Transifex are incorporated. + +CVE-2019-12781: Incorrect HTTP detection with reverse-proxy connecting via HTTPS +-------------------------------------------------------------------------------- + +When deployed behind a reverse-proxy connecting to Django via HTTPS, +:attr:`django.http.HttpRequest.scheme` would incorrectly detect client +requests made via HTTP as using HTTPS. This entails incorrect results for +:meth:`~django.http.HttpRequest.is_secure`, and +:meth:`~django.http.HttpRequest.build_absolute_uri`, and that HTTP +requests would not be redirected to HTTPS in accordance with +:setting:`SECURE_SSL_REDIRECT`. + +``HttpRequest.scheme`` now respects :setting:`SECURE_PROXY_SSL_HEADER`, if it is +configured, and the appropriate header is set on the request, for both HTTP and +HTTPS requests. + +If you deploy Django behind a reverse-proxy that forwards HTTP requests, and +that connects to Django via HTTPS, be sure to verify that your application +correctly handles code paths relying on ``scheme``, ``is_secure()``, +``build_absolute_uri()``, and ``SECURE_SSL_REDIRECT``. Bugfixes ======== |