diff options
| author | Karen Tracey <kmtracey@gmail.com> | 2008-11-13 19:03:42 +0000 |
|---|---|---|
| committer | Karen Tracey <kmtracey@gmail.com> | 2008-11-13 19:03:42 +0000 |
| commit | dfa90aec1bed28f581b0f0471dc95860bb166cc9 (patch) | |
| tree | 232dbc1006d2b547bef64f4fe0ab241bb69c7825 /django/utils/_os.py | |
| parent | 5c4fcbb19b3254442b702ce1153b639a2338194b (diff) | |
Fixed #9579 -- Properly handle apps running with (and specifically, loading templates from) a current working directory path that contains non-ASCII characters. Thanks for the report to gonzalodelgado and for advice on how to fix it to Daniel Pope.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9411 bcc190cf-cafb-0310-a4f2-bffc1f526a37
Diffstat (limited to 'django/utils/_os.py')
| -rw-r--r-- | django/utils/_os.py | 26 |
1 files changed, 23 insertions, 3 deletions
diff --git a/django/utils/_os.py b/django/utils/_os.py index 39ba9f2112..d75714bce1 100644 --- a/django/utils/_os.py +++ b/django/utils/_os.py @@ -1,6 +1,26 @@ -from os.path import join, normcase, abspath, sep +import os +from os.path import join, normcase, normpath, abspath, isabs, sep from django.utils.encoding import force_unicode +# Define our own abspath function that can handle joining +# unicode paths to a current working directory that has non-ASCII +# characters in it. This isn't necessary on Windows since the +# Windows version of abspath handles this correctly. The Windows +# abspath also handles drive letters differently than the pure +# Python implementation, so it's best not to replace it. +if os.name == 'nt': + abspathu = abspath +else: + def abspathu(path): + """ + Version of os.path.abspath that uses the unicode representation + of the current working directory, thus avoiding a UnicodeDecodeError + in join when the cwd has non-ASCII characters. + """ + if not isabs(path): + path = join(os.getcwdu(), path) + return normpath(path) + def safe_join(base, *paths): """ Joins one or more path components to the base path component intelligently. @@ -13,8 +33,8 @@ def safe_join(base, *paths): # insensitive operating systems (like Windows). base = force_unicode(base) paths = [force_unicode(p) for p in paths] - final_path = normcase(abspath(join(base, *paths))) - base_path = normcase(abspath(base)) + final_path = normcase(abspathu(join(base, *paths))) + base_path = normcase(abspathu(base)) base_path_len = len(base_path) # Ensure final_path starts with base_path and that the next character after # the final path is os.sep (or nothing, in which case final_path must be |
