summaryrefslogtreecommitdiff
path: root/django/urls
diff options
context:
space:
mode:
authorAlokik Vijay <alokik.roe@gmail.com>2022-05-17 09:46:26 +0200
committerCarlton Gibson <carlton@noumenal.es>2022-05-17 10:50:09 +0200
commit7f3cfaa12b28d15c0ca78bb692bfd6e59d17bff1 (patch)
treeb9da3508b15e3bbbb42332f282ce8e0075f5d7e0 /django/urls
parent2a5d2eefc751be012fdebd75d8177c42bf5a76fc (diff)
Fixed #32565 -- Moved internal URLResolver view-strings mapping to admindocs.
Moved the functionality of URLResolver._is_callback(), URLResolver._callback_strs, URLPattern.lookup_str() to django.contrib.admindocs.
Diffstat (limited to 'django/urls')
-rw-r--r--django/urls/resolvers.py25
1 files changed, 0 insertions, 25 deletions
diff --git a/django/urls/resolvers.py b/django/urls/resolvers.py
index 9f42e2738c..7c0d4fd85a 100644
--- a/django/urls/resolvers.py
+++ b/django/urls/resolvers.py
@@ -437,21 +437,6 @@ class URLPattern:
extra_kwargs=self.default_args,
)
- @cached_property
- def lookup_str(self):
- """
- A string that identifies the view (e.g. 'path.to.view_function' or
- 'path.to.ClassBasedView').
- """
- callback = self.callback
- if isinstance(callback, functools.partial):
- callback = callback.func
- if hasattr(callback, "view_class"):
- callback = callback.view_class
- elif not hasattr(callback, "__name__"):
- return callback.__module__ + "." + callback.__class__.__name__
- return callback.__module__ + "." + callback.__qualname__
-
class URLResolver:
def __init__(
@@ -469,9 +454,6 @@ class URLResolver:
self._reverse_dict = {}
self._namespace_dict = {}
self._app_dict = {}
- # set of dotted paths to all functions and classes that are used in
- # urlpatterns
- self._callback_strs = set()
self._populated = False
self._local = Local()
@@ -545,7 +527,6 @@ class URLResolver:
if p_pattern.startswith("^"):
p_pattern = p_pattern[1:]
if isinstance(url_pattern, URLPattern):
- self._callback_strs.add(url_pattern.lookup_str)
bits = normalize(url_pattern.pattern.regex.pattern)
lookups.appendlist(
url_pattern.callback,
@@ -604,7 +585,6 @@ class URLResolver:
namespaces[namespace] = (p_pattern + prefix, sub_pattern)
for app_name, namespace_list in url_pattern.app_dict.items():
apps.setdefault(app_name, []).extend(namespace_list)
- self._callback_strs.update(url_pattern._callback_strs)
self._namespace_dict[language_code] = namespaces
self._app_dict[language_code] = apps
self._reverse_dict[language_code] = lookups
@@ -649,11 +629,6 @@ class URLResolver:
route2 = route2[1:]
return route1 + route2
- def _is_callback(self, name):
- if not self._populated:
- self._populate()
- return name in self._callback_strs
-
def resolve(self, path):
path = str(path) # path may be a reverse_lazy object
tried = []