summaryrefslogtreecommitdiff
path: root/django/middleware/common.py
diff options
context:
space:
mode:
authorDenis Cornehl <syphar@fastmail.fm>2016-01-05 08:09:10 +0100
committerTim Graham <timograham@gmail.com>2016-01-05 09:37:11 -0500
commit186b6c61bfe85afa4d6bf213d04a28dd2853fed2 (patch)
treee068a17145cf17f4eaf887ecfc84d39ab150ced6 /django/middleware/common.py
parentd5b90c8e120687863c1d41cf92a4cdb11413ad7f (diff)
Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag support.
Thanks Denis Cornehl for help with the patch.
Diffstat (limited to 'django/middleware/common.py')
-rw-r--r--django/middleware/common.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/django/middleware/common.py b/django/middleware/common.py
index c7b1c1c772..c2eb88631c 100644
--- a/django/middleware/common.py
+++ b/django/middleware/common.py
@@ -8,6 +8,7 @@ from django.core.mail import mail_managers
from django.urls import is_valid_path
from django.utils.cache import get_conditional_response, set_response_etag
from django.utils.encoding import force_text
+from django.utils.http import unquote_etag
from django.utils.six.moves.urllib.parse import urlparse
logger = logging.getLogger('django.request')
@@ -120,9 +121,7 @@ class CommonMiddleware(object):
if response.has_header('ETag'):
return get_conditional_response(
request,
- # get_conditional_response() requires an unquoted version
- # of the response's ETag.
- etag=response['ETag'].strip('"'),
+ etag=unquote_etag(response['ETag']),
response=response,
)