summaryrefslogtreecommitdiff
path: root/django/http
diff options
context:
space:
mode:
authorJacob Walls <jacobtylerwalls@gmail.com>2025-10-16 16:28:33 -0400
committerNatalia <124304+nessita@users.noreply.github.com>2025-11-05 09:52:56 -0300
commit770eea38d7a0e9ba9455140b5a9a9e33618226a7 (patch)
treead731e4465db6a4ee3f88c609612ce0aa473ea9a /django/http
parent80976bd89e9e1fdfb98c4d902ca4dc59bd3d1d46 (diff)
[4.2.x] Fixed CVE-2025-64458 -- Mitigated potential DoS in HttpResponseRedirect/HttpResponsePermanentRedirect on Windows.
Thanks Seokchan Yoon for the report, Markus Holtermann for the triage, and Jake Howard for the review. Backport of c880530ddd4fabd5939bab0e148bebe36699432a from main.
Diffstat (limited to 'django/http')
-rw-r--r--django/http/response.py9
1 files changed, 7 insertions, 2 deletions
diff --git a/django/http/response.py b/django/http/response.py
index ea3114170e..763fd2a8ac 100644
--- a/django/http/response.py
+++ b/django/http/response.py
@@ -21,7 +21,7 @@ from django.http.cookie import SimpleCookie
from django.utils import timezone
from django.utils.datastructures import CaseInsensitiveMapping
from django.utils.encoding import iri_to_uri
-from django.utils.http import content_disposition_header, http_date
+from django.utils.http import MAX_URL_LENGTH, content_disposition_header, http_date
from django.utils.regex_helper import _lazy_re_compile
_charset_from_content_type_re = _lazy_re_compile(
@@ -614,7 +614,12 @@ class HttpResponseRedirectBase(HttpResponse):
def __init__(self, redirect_to, *args, **kwargs):
super().__init__(*args, **kwargs)
self["Location"] = iri_to_uri(redirect_to)
- parsed = urlparse(str(redirect_to))
+ redirect_to_str = str(redirect_to)
+ if len(redirect_to_str) > MAX_URL_LENGTH:
+ raise DisallowedRedirect(
+ f"Unsafe redirect exceeding {MAX_URL_LENGTH} characters"
+ )
+ parsed = urlparse(redirect_to_str)
if parsed.scheme and parsed.scheme not in self.allowed_schemes:
raise DisallowedRedirect(
"Unsafe redirect to URL with protocol '%s'" % parsed.scheme