Fixed #29159 -- Made ModelChoiceIterator reuse QuerySet result cache.

When __len__() is called (e.g. when casting to list or tuple), the
QuerySet is evaluated and the result cache populated. iterator()
shouldn't be called on the QuerySet after that, as it would reset the
result cache and trigger a second query.

1 files changed, 1 insertions, 1 deletions

diff --git a/django/forms/models.py b/django/forms/models.py
index 8134cf3de3..414a9eafe4 100644
--- a/django/forms/models.py
+++ b/django/forms/models.py
@@ -1132,7 +1132,7 @@ class ModelChoiceIterator:
             yield ("", self.field.empty_label)
         queryset = self.queryset
         # Can't use iterator() when queryset uses prefetch_related()
-        if not queryset._prefetch_related_lookups:
+        if not queryset._prefetch_related_lookups and queryset._result_cache is None:
             queryset = queryset.iterator()
         for obj in queryset:
             yield self.choice(obj)