summaryrefslogtreecommitdiff
path: root/django/forms
diff options
context:
space:
mode:
authorFrancesco Panico <panico.francesco@gmail.com>2022-11-17 22:45:06 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2022-11-18 08:06:13 +0100
commit51faf4bd172cd4cb219a9793facbfa00246c9f3c (patch)
tree8dd28c9fee31b34267ff0b7d25853fba2280e3f8 /django/forms
parentfbde929b19754f19cba1d14e86f4c59f4b0a633c (diff)
Fixed #34148 -- Reverted "Fixed #32901 -- Optimized BaseForm.__getitem__()."
This reverts commit edde2a069929c93e37835dc3f7c9a229040058e2. Thanks Jan Pieter Waagmeester for the report.
Diffstat (limited to 'django/forms')
-rw-r--r--django/forms/forms.py10
1 files changed, 3 insertions, 7 deletions
diff --git a/django/forms/forms.py b/django/forms/forms.py
index 7c9f1034d2..6884e6e724 100644
--- a/django/forms/forms.py
+++ b/django/forms/forms.py
@@ -175,10 +175,6 @@ class BaseForm(RenderableFormMixin):
def __getitem__(self, name):
"""Return a BoundField with the given name."""
try:
- return self._bound_fields_cache[name]
- except KeyError:
- pass
- try:
field = self.fields[name]
except KeyError:
raise KeyError(
@@ -189,9 +185,9 @@ class BaseForm(RenderableFormMixin):
", ".join(sorted(self.fields)),
)
)
- bound_field = field.get_bound_field(self, name)
- self._bound_fields_cache[name] = bound_field
- return bound_field
+ if name not in self._bound_fields_cache:
+ self._bound_fields_cache[name] = field.get_bound_field(self, name)
+ return self._bound_fields_cache[name]
@property
def errors(self):