summaryrefslogtreecommitdiff
path: root/django/db/models/sql
diff options
context:
space:
mode:
authorTim Graham <timograham@gmail.com>2017-12-07 17:13:07 -0500
committerGitHub <noreply@github.com>2017-12-07 17:13:07 -0500
commit2b81faab257832d3dbd42947a884f7ec99685d18 (patch)
treef6fbaefb4284567bcd0a0e2a27a6ce36938aaef3 /django/db/models/sql
parent02d9419fe34eaa4d41d8a8df93373f286a36a2ae (diff)
Fixed #28906 -- Removed unnecessary bool() calls.
Diffstat (limited to 'django/db/models/sql')
-rw-r--r--django/db/models/sql/compiler.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/django/db/models/sql/compiler.py b/django/db/models/sql/compiler.py
index 2b0590de3a..9e381fd269 100644
--- a/django/db/models/sql/compiler.py
+++ b/django/db/models/sql/compiler.py
@@ -1215,12 +1215,10 @@ class SQLInsertCompiler(SQLCompiler):
qn = self.connection.ops.quote_name
opts = self.query.get_meta()
result = ['INSERT INTO %s' % qn(opts.db_table)]
-
- has_fields = bool(self.query.fields)
- fields = self.query.fields if has_fields else [opts.pk]
+ fields = self.query.fields or [opts.pk]
result.append('(%s)' % ', '.join(qn(f.column) for f in fields))
- if has_fields:
+ if self.query.fields:
value_rows = [
[self.prepare_value(field, self.pre_save_val(field, obj)) for field in fields]
for obj in self.query.objs