diff options
| author | Loic Bistuer <loic.bistuer@sixmedia.com> | 2013-09-27 06:35:53 +0700 |
|---|---|---|
| committer | Anssi Kääriäinen <akaariai@gmail.com> | 2013-11-27 19:44:18 +0200 |
| commit | 17c3997f6828e88e4646071a8187c1318b65597d (patch) | |
| tree | ccc0344dcebc39987ced53c850a5bb8bdb97814f /django/db/models/sql/query.py | |
| parent | 0b3c8fc85168bac7327e7c4372e92b52575547e9 (diff) | |
Fixed #21169 -- Reworked RelatedManager methods use default filtering
The `remove()` and `clear()` methods of the related managers created by
`ForeignKey`, `GenericForeignKey`, and `ManyToManyField` suffered from a
number of issues. Some operations ran multiple data modifying queries without
wrapping them in a transaction, and some operations didn't respect default
filtering when it was present (i.e. when the default manager on the related
model implemented a custom `get_queryset()`).
Fixing the issues introduced some backward incompatible changes:
- The implementation of `remove()` for `ForeignKey` related managers changed
from a series of `Model.save()` calls to a single `QuerySet.update()` call.
The change means that `pre_save` and `post_save` signals aren't called anymore.
- The `remove()` and `clear()` methods for `GenericForeignKey` related
managers now perform bulk delete so `Model.delete()` isn't called anymore.
- The `remove()` and `clear()` methods for `ManyToManyField` related
managers perform nested queries when filtering is involved, which may
or may not be an issue depending on the database and the data itself.
Refs. #3871, #21174.
Thanks Anssi Kääriäinen and Tim Graham for the reviews.
Diffstat (limited to 'django/db/models/sql/query.py')
0 files changed, 0 insertions, 0 deletions
