diff options
| author | Rajiv Makhijani <rajiv@blue-tech.org> | 2014-08-08 03:08:26 -0700 |
|---|---|---|
| committer | Anssi Kääriäinen <akaariai@gmail.com> | 2014-08-11 09:33:18 +0300 |
| commit | f0b358880a6825d667c037757caac470bc526a1f (patch) | |
| tree | f44749b352a17651ca826a115a85d98c07b28598 /django/db/models/sql/compiler.py | |
| parent | 12ad61aa9ff92958d56bb5b0c0c372e24a596148 (diff) | |
Fixed #23259 -- Corrected insertion order of extra() select_params
A regression caused queries to produce incorrect results for cases where
extra(select) is excluded by values() but included by extra(order_by)
The regression was caused by 2f35c6f10fcbae541691207fb0c0560a13b754fc.
Diffstat (limited to 'django/db/models/sql/compiler.py')
| -rw-r--r-- | django/db/models/sql/compiler.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/django/db/models/sql/compiler.py b/django/db/models/sql/compiler.py index 294e0b21fd..82438355cb 100644 --- a/django/db/models/sql/compiler.py +++ b/django/db/models/sql/compiler.py @@ -117,7 +117,7 @@ class SQLCompiler(object): if self.query.distinct: result.append(self.connection.ops.distinct_sql(distinct_fields)) - params.extend(o_params) + result.append(', '.join(out_cols + self.ordering_aliases)) params.extend(s_params) params.extend(self.ordering_params) @@ -146,6 +146,7 @@ class SQLCompiler(object): if ordering: result.append('ORDER BY %s' % ', '.join(ordering)) + params.extend(o_params) if with_limits: if self.query.high_mark is not None: |