summaryrefslogtreecommitdiff
path: root/django/db/models/sql/__init__.py
diff options
context:
space:
mode:
authorJacob Walls <jacobtylerwalls@gmail.com>2026-01-21 17:53:52 -0500
committerJacob Walls <jacobtylerwalls@gmail.com>2026-02-03 08:26:22 -0500
commit90f5b10784ba5bf369caed87640e2b4394ea3314 (patch)
treedc486cf43314310a8b528fd8b655ab1a5b71fda8 /django/db/models/sql/__init__.py
parentf75f8f3597e1ce351d5ac08b6ba7ebd9dadd9b5d (diff)
[4.2.x] Fixed CVE-2026-1312 -- Protected order_by() from SQL injection via aliases with periods.
Before, `order_by()` treated a period in a field name as a sign that it was requested via `.extra(order_by=...)` and thus should be passed through as raw table and column names, even if `extra()` was not used. Since periods are permitted in aliases, this meant user-controlled aliases could force the `order_by()` clause to resolve to a raw table and column pair instead of the actual target field for the alias. In practice, only `FilteredRelation` was affected, as the other expressions we tested, e.g. `F`, aggressively optimize away the ordering expressions into ordinal positions, e.g. ORDER BY 2, instead of ORDER BY "table".column. Thanks Solomon Kebede for the report, and Simon Charette and Jake Howard for reviews. Backport of 69065ca869b0970dff8fdd8fafb390bf8b3bf222 from main.
Diffstat (limited to 'django/db/models/sql/__init__.py')
0 files changed, 0 insertions, 0 deletions