summaryrefslogtreecommitdiff
path: root/django/db/models/functions/datetime.py
diff options
context:
space:
mode:
authorMariusz Felisiak <felisiak.mariusz@gmail.com>2022-06-22 12:44:04 +0200
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2022-07-04 08:26:57 +0200
commit0dc9c016fadb71a067e5a42be30164e3f96c0492 (patch)
treeca672f9aad4b7a05802d27c5a22bede0ddd1c419 /django/db/models/functions/datetime.py
parenta2b88d7be6fc9b443794518d2f75fd2f3d9e677a (diff)
[4.0.x] Fixed CVE-2022-34265 -- Protected Trunc(kind)/Extract(lookup_name) against SQL injection.
Thanks Takuto Yoshikai (Aeye Security Lab) for the report.
Diffstat (limited to 'django/db/models/functions/datetime.py')
-rw-r--r--django/db/models/functions/datetime.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/django/db/models/functions/datetime.py b/django/db/models/functions/datetime.py
index 2d6ec7089e..5f98e6bba1 100644
--- a/django/db/models/functions/datetime.py
+++ b/django/db/models/functions/datetime.py
@@ -51,6 +51,8 @@ class Extract(TimezoneMixin, Transform):
super().__init__(expression, **extra)
def as_sql(self, compiler, connection):
+ if not connection.ops.extract_trunc_lookup_pattern.fullmatch(self.lookup_name):
+ raise ValueError("Invalid lookup_name: %s" % self.lookup_name)
sql, params = compiler.compile(self.lhs)
lhs_output_field = self.lhs.output_field
if isinstance(lhs_output_field, DateTimeField):
@@ -235,6 +237,8 @@ class TruncBase(TimezoneMixin, Transform):
super().__init__(expression, output_field=output_field, **extra)
def as_sql(self, compiler, connection):
+ if not connection.ops.extract_trunc_lookup_pattern.fullmatch(self.kind):
+ raise ValueError("Invalid kind: %s" % self.kind)
inner_sql, inner_params = compiler.compile(self.lhs)
tzname = None
if isinstance(self.lhs.output_field, DateTimeField):