diff options
| author | daniel a rios <misterrios@gmail.com> | 2019-10-08 11:02:40 +0200 |
|---|---|---|
| committer | Mariusz Felisiak <felisiak.mariusz@gmail.com> | 2019-11-14 11:14:11 +0100 |
| commit | efc3e32d6d7fb9bb41be73b80c8607b653c1fbd6 (patch) | |
| tree | fff79e28232a2d8088aee861606c924424771395 /django/core/cache/backends/memcached.py | |
| parent | 6e99585c19290fb9bec502cac8210041fdb28484 (diff) | |
Fixed #30759 -- Made cache.delete() return whether it succeeded.
Thanks Simon Charette for the review.
Diffstat (limited to 'django/core/cache/backends/memcached.py')
| -rw-r--r-- | django/core/cache/backends/memcached.py | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/django/core/cache/backends/memcached.py b/django/core/cache/backends/memcached.py index 48cfb8310b..8202005045 100644 --- a/django/core/cache/backends/memcached.py +++ b/django/core/cache/backends/memcached.py @@ -78,7 +78,7 @@ class BaseMemcachedCache(BaseCache): def delete(self, key, version=None): key = self.make_key(key, version=version) - self._cache.delete(key) + return bool(self._cache.delete(key)) def get_many(self, keys, version=None): key_map = {self.make_key(key, version=version): key for key in keys} @@ -170,6 +170,13 @@ class MemcachedCache(BaseMemcachedCache): return default return val + def delete(self, key, version=None): + # python-memcached's delete() returns True when key doesn't exist. + # https://github.com/linsomniac/python-memcached/issues/170 + # Call _deletetouch() without the NOT_FOUND in expected results. + key = self.make_key(key, version=version) + return bool(self._cache._deletetouch([b'DELETED'], 'delete', key)) + class PyLibMCCache(BaseMemcachedCache): "An implementation of a cache binding using pylibmc" |
