summaryrefslogtreecommitdiff
path: root/django/contrib/gis/forms
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2018-02-06 11:51:41 +0100
committerTim Graham <timograham@gmail.com>2018-04-02 10:20:00 -0400
commit2a2ed0e70a93bfd1a3d41af40870fe963dc2687d (patch)
treea23d1526aab1324798e431f78d9327c734a66a92 /django/contrib/gis/forms
parent09c6d0146178d83b6bd6cc8bb4162a5ae7c1c5f5 (diff)
Fixed #29116 -- Fixed OpenLayersWidget deserialization ignoring the widget map's SRID.
Regression in 6ecccad711b52f9273b1acb07a57d3f806e93928.
Diffstat (limited to 'django/contrib/gis/forms')
-rw-r--r--django/contrib/gis/forms/fields.py11
-rw-r--r--django/contrib/gis/forms/widgets.py10
2 files changed, 17 insertions, 4 deletions
diff --git a/django/contrib/gis/forms/fields.py b/django/contrib/gis/forms/fields.py
index afb0974415..d05518c971 100644
--- a/django/contrib/gis/forms/fields.py
+++ b/django/contrib/gis/forms/fields.py
@@ -35,9 +35,14 @@ class GeometryField(forms.Field):
return None
if not isinstance(value, GEOSGeometry):
- try:
- value = GEOSGeometry(value)
- except (GEOSException, ValueError, TypeError):
+ if hasattr(self.widget, 'deserialize'):
+ value = self.widget.deserialize(value)
+ else:
+ try:
+ value = GEOSGeometry(value)
+ except (GEOSException, ValueError, TypeError):
+ value = None
+ if value is None:
raise forms.ValidationError(self.error_messages['invalid_geom'], code='invalid_geom')
# Try to set the srid
diff --git a/django/contrib/gis/forms/widgets.py b/django/contrib/gis/forms/widgets.py
index 0ffe2ced77..cd9bff9f68 100644
--- a/django/contrib/gis/forms/widgets.py
+++ b/django/contrib/gis/forms/widgets.py
@@ -2,6 +2,7 @@ import logging
from django.conf import settings
from django.contrib.gis import gdal
+from django.contrib.gis.geometry import json_regex
from django.contrib.gis.geos import GEOSException, GEOSGeometry
from django.forms.widgets import Widget
from django.utils import translation
@@ -36,7 +37,7 @@ class BaseGeometryWidget(Widget):
def deserialize(self, value):
try:
return GEOSGeometry(value)
- except (GEOSException, ValueError) as err:
+ except (GEOSException, ValueError, TypeError) as err:
logger.error("Error creating geometry from value '%s' (%s)", value, err)
return None
@@ -91,6 +92,13 @@ class OpenLayersWidget(BaseGeometryWidget):
def serialize(self, value):
return value.json if value else ''
+ def deserialize(self, value):
+ geom = super().deserialize(value)
+ # GeoJSON assumes WGS84 (4326). Use the map's SRID instead.
+ if geom and json_regex.match(value) and self.map_srid != 4326:
+ geom.srid = self.map_srid
+ return geom
+
class OSMWidget(OpenLayersWidget):
"""