diff options
| author | Tim Graham <timograham@gmail.com> | 2018-06-14 14:22:04 -0400 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2018-06-15 10:12:40 -0400 |
| commit | 4bccfac36fa765494cbaa03f79453f97a92ec921 (patch) | |
| tree | 2aceacb7f4c9b8859dda20e75803b9e7b4e59c03 /django/contrib/admin/views/main.py | |
| parent | 9dfb6fcbd5cc938a6c6639eafdf9ed53b751f6a0 (diff) | |
[2.0.x] Fixed #29428 -- Fixed admin changelist crash when using a query expression without asc()/desc() in the ordering.
Backport of 0d8e3e608ee9aab5076d497664aa97e0a29e523e from master
Diffstat (limited to 'django/contrib/admin/views/main.py')
| -rw-r--r-- | django/contrib/admin/views/main.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/django/contrib/admin/views/main.py b/django/contrib/admin/views/main.py index 495ab8e4a0..0e266b4b1f 100644 --- a/django/contrib/admin/views/main.py +++ b/django/contrib/admin/views/main.py @@ -15,7 +15,7 @@ from django.core.exceptions import ( ) from django.core.paginator import InvalidPage from django.db import models -from django.db.models.expressions import F, OrderBy +from django.db.models.expressions import Combinable, F, OrderBy from django.urls import reverse from django.utils.http import urlencode from django.utils.translation import gettext @@ -289,7 +289,9 @@ class ChangeList: # the right column numbers absolutely, because there might be more # than one column associated with that ordering, so we guess. for field in ordering: - if isinstance(field, OrderBy): + if isinstance(field, (Combinable, OrderBy)): + if not isinstance(field, OrderBy): + field = field.asc() if isinstance(field.expression, F): order_type = 'desc' if field.descending else 'asc' field = field.expression.name |
