diff options
| author | Andrew Miller <info@akmiller.co.uk> | 2024-12-15 21:04:29 +0000 |
|---|---|---|
| committer | Sarah Boyce <42296566+sarahboyce@users.noreply.github.com> | 2024-12-18 13:08:14 +0100 |
| commit | 3ee4c6a27ad520d4ecc3cded260d47cbccafb144 (patch) | |
| tree | 6b40c303a597ad552204c1e56a27fa8cef4e7774 | |
| parent | 0fc6d5362bfed3e2222fa3476139126ee08a4ff9 (diff) | |
Refs #26007 -- Improved the ImproperlyConfigured error message for SingleObjectTemplateResponseMixin.get_template_names().
| -rw-r--r-- | django/views/generic/detail.py | 6 | ||||
| -rw-r--r-- | tests/generic_views/test_base.py | 5 |
2 files changed, 8 insertions, 3 deletions
diff --git a/django/views/generic/detail.py b/django/views/generic/detail.py index 05ced1f25d..70e427c59b 100644 --- a/django/views/generic/detail.py +++ b/django/views/generic/detail.py @@ -171,7 +171,11 @@ class SingleObjectTemplateResponseMixin(TemplateResponseMixin): # If we still haven't managed to find any template names, we should # re-raise the ImproperlyConfigured to alert the user. if not names: - raise + raise ImproperlyConfigured( + "SingleObjectTemplateResponseMixin requires a definition " + "of 'template_name', 'template_name_field', or 'model'; " + "or an implementation of 'get_template_names()'." + ) return names diff --git a/tests/generic_views/test_base.py b/tests/generic_views/test_base.py index add485245a..5f3941196b 100644 --- a/tests/generic_views/test_base.py +++ b/tests/generic_views/test_base.py @@ -607,8 +607,9 @@ class SingleObjectTemplateResponseMixinTest(SimpleTestCase): """ view = views.TemplateResponseWithoutTemplate() msg = ( - "TemplateResponseMixin requires either a definition of " - "'template_name' or an implementation of 'get_template_names()'" + "SingleObjectTemplateResponseMixin requires a definition " + "of 'template_name', 'template_name_field', or 'model'; " + "or an implementation of 'get_template_names()'." ) with self.assertRaisesMessage(ImproperlyConfigured, msg): view.get_template_names() |