summaryrefslogtreecommitdiff
path: root/tests/regressiontests/comment_tests
AgeCommit message (Collapse)Author
2013-02-26Merged regressiontests and modeltests into the test root.Florian Apolloner
2013-02-24Fixed #16302 -- Ensure contrib.comments is IPv6 capableErik Romijn
Changed the ip_address field for Comment to GenericIPAddressField. Added instructions to the release notes on how to update the schema of existing databases.
2013-02-08Cleaned up some lingering signals in the test suite that were causing ↵Julien Phalip
spurious failures with Pypy and Postgres.
2013-02-06Fixed #19704 -- Make use of new ungettext_lazy function at appropriate placesAlexey Boriskin
2012-12-16Fixed #19483 -- Improved import error message in contrib.commentsClaude Paroz
Thanks Valentin Lorentz for the report and the suggested fix.
2012-12-10Fixed a test failure in the comment tests.Florian Apolloner
2012-12-10Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users.Florian Apolloner
2012-10-26Fixed comment_test tests under hash randomization.Aymeric Augustin
Thanks clelland for the patch.
2012-09-28Used get_current_site in comments feed classClaude Paroz
2012-09-08Remove an outdated import inadvertently introduced in tests.Carl Meyer
2012-09-08Fixed #15552 -- LOGIN_URL and LOGIN_REDIRECT_URL can take URLpattern names.Carl Meyer
Thanks UloPe and Eric Florenzano for the patch, and Malcolm Tredinnick for review.
2012-08-12[py3] Refactored __unicode__ to __str__.Aymeric Augustin
* Renamed the __unicode__ methods * Applied the python_2_unicode_compatible decorator * Removed the StrAndUnicode mix-in that is superseded by python_2_unicode_compatible * Kept the __unicode__ methods in classes that specifically test it under Python 2
2012-08-12[py3] Replaced some __str__ methods by __unicode__Aymeric Augustin
These methods actually return unicode.
2012-06-07Fixed #18269 -- Applied unicode_literals for Python 3 compatibility.Claude Paroz
Thanks Vinay Sajip for the support of his django3 branch and Jannis Leidel for the review.
2012-04-30Ensured tests pass using custom PASSWORD_HASHERS.Anssi Kääriäinen
2012-04-14Converted more test assertions to assert[Not]Contains.Claude Paroz
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17910 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-30Removed with_statement imports, useless in Python >= 2.6. Refs #17965. ↵Claude Paroz
Thanks jonash for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17828 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-15Added a `with_statement` import to a test for Python 2.5 compatibility.Julien Phalip
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17746 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-15Fixed #17838 - prefetch_related fails for GenericForeignKeys when related ↵Luke Plant
object id is not a CharField/TextField Thanks to mkai for the report and debugging, and tmitchell and Przemek Lewandowski for their work on the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17744 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-02-11Fixed #17256 -- Ensured that content types get cached when retrieved by ↵Julien Phalip
natural key. Thanks, defaultwombat and charettes. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17502 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-02-11Fix the other test for #15237.Paul McMillan
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17495 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-14Switch several assertNumQueries to use the context manager, which is much ↵Alex Gaynor
more beautiful. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16986 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-13Convert much of the regression tests to use absolute imports. There's still ↵Alex Gaynor
work to be done though. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16976 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-11Fixed #14675 -- Completed removal of `from django.conf.urls.default import ↵Ramiro Morales
*` usage. This applies to both our own [test] code and documentation examples. Also: * Moved the functions and handlers from `django.conf.urls.defaults` up to `django.conf.urls` deprecating the former module. * Added documentation for `handler403`. * Tweaked the URLs topic document a bit. Thanks to pupeno and cdestigter for their great work contributing patches. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16818 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-09Fixed #16042 -- Use the content types caching in the comments contrib app. ↵Jannis Leidel
Thanks, ptone, Julien Phalip and Thejaswi Puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16737 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-13Fixed #16225 -- Removed unused imports. Many thanks to Aymeric Augustin for ↵Jannis Leidel
the work on the patch and Alex for reviewing. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16539 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-26Fixed #15904 - render_comment_form executes unnecessary query for objectLuke Plant
Thanks to stefanw for report and patch! git-svn-id: http://code.djangoproject.com/svn/django/trunk@16103 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-04-02Updates to the test suite to allow for newly deprecated and removed featuresRussell Keith-Magee
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15990 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-30Removed Django 1.2 compatibility fallback for contrib.comments forms hash.Luke Plant
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15953 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-28Removed a bunch more Python 2.4 workarounds now that we don't support that ↵Adrian Holovaty
version. Refs #15702 -- thanks to jonash for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15927 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-03Updated test assertions that have been deprecated by the move to unittest2. ↵Russell Keith-Magee
In summary, this means: assert_ -> assertTrue assertEquals -> assertEqual failUnless -> assertTrue For full details, see http://www.voidspace.org.uk/python/articles/unittest2.shtml#deprecations git-svn-id: http://code.djangoproject.com/svn/django/trunk@15728 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-03-03Fixed #13411 -- Made sure URL fragments are correctly handled by the ↵Jannis Leidel
next_redirect utility of the comments apps. Thanks, timesong, dpn and Julien Phalip. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15720 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-13Fixed #14176 -- Added forwards compatibility to the legacy syndication feed ↵Russell Keith-Magee
view. This allows class-based feeds to be deployed using the old-style feed view, as long as the feed requires no arguments (i.e., get_object returns None). Thanks to psychcf for the report, cwhaines for the investigation, and Andrew Godwin for the assist. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15189 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-21Fixed #13743 -- Fixed CommentsAdmin to not blow up if the delete_selected ↵Jannis Leidel
action is disabled. Thanks, Daniel Lindsley. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14996 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-04Removed all usages of deprecated TestCase methods (self.fail*). This ↵Alex Gaynor
removed most of the Warnings emitted (with -Wall) during the test suite. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14803 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-13Fixed #12325 -- Allows zero values for moderate_after and close_after fields ↵Jannis Leidel
of comment moderators. Thanks, Gabriel Hurley. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14556 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-14Fixed #14445 - Use HMAC and constant-time comparison functions where needed.Luke Plant
All adhoc MAC applications have been updated to use HMAC, using SHA1 to generate unique keys for each application based on the SECRET_KEY, which is common practice for this situation. In all cases, backwards compatibility with existing hashes has been maintained, aiming to phase this out as per the normal deprecation process. In this way, under most normal circumstances the old hashes will have expired (e.g. by session expiration etc.) before they become invalid. In the case of the messages framework and the cookie backend, which was already using HMAC, there is the possibility of a backwards incompatibility if the SECRET_KEY is shorter than the default 50 bytes, but the low likelihood and low impact meant compatibility code was not worth it. All known instances where tokens/hashes were compared using simple string equality, which could potentially open timing based attacks, have also been fixed using a constant-time comparison function. There are no known practical attacks against the existing implementations, so these security improvements will not be backported. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-09Fixed a typo in the comments tests, as well as a dependency on CPython's ↵Alex Gaynor
reference counting semantics. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14098 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-09-26Fixed #13827 -- Cleaned up a few unnecessary function calls.Jannis Leidel
git-svn-id: http://code.djangoproject.com/svn/django/trunk@13876 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-05-10Fixed #13509 -- Modified the comment tests so that signal cleanup doesn't ↵Russell Keith-Magee
rely on garbage collection. Thanks to Alex Gaynor for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@13204 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-16Changed the comments post view code to avoid raising an exception if handed ↵Karen Tracey
invalid data for the object pk. Thanks to Leo for the test. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12800 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-03-05Fixed #12151: Ensured the comments code does not cause a server error when a ↵Karen Tracey
request comes in for a comment specifying an invalid primary key value. Thanks thejaswi_puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12681 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-28Fixed #12724: Fixed new comment tests to not hardcode comment primary key ↵Karen Tracey
values. Thanks carljm. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12345 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04Fixed #10285 - Added render_comment_list template tag to comments app. ↵Jannis Leidel
Thanks Kyle Fuller for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12082 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04Fixed #11100 - Added get_comment_permalink template tag to comments app to ↵Jannis Leidel
be able to customize the anchor pattern of a comment from the template. Thanks to Idan Gazit for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12080 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-24Fixed a couple of test-ordering-dependant failures introduced in [11639] ↵Jacob Kaplan-Moss
that caused test failures when running the whole test suite. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11645 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-10-23Fixed #11625: added comment moderation via admin actions.Jacob Kaplan-Moss
This is BACKWARDS INCOMPATIBLE if you were using the completely undocumented moderation view from 1.1. That view's been removed in favor of the admin actions. Thanks, Thejaswi Puthraya. git-svn-id: http://code.djangoproject.com/svn/django/trunk@11639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15Corrected tests from [10784]; instead of retrieving two comments, it was ↵James Bennett
retrieving one comment twice. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10785 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14Fixed #11113: fixed a couple of issues that slipped through the cracks when ↵Jacob Kaplan-Moss
comment moderation was added to `django.contrib.comments`. The is a potentially backwards-incompatible change for users already relying on the internals of comment moderaration. To wit: * The moderation system now listens to the new `comment_will_be_posted`/`comment_was_posted` signals instead of `pre/post_save`. This means that import request-based information is available to moderation as it should be. * Some experimental code from `django.contrib.comments.moderation` has been removed. It was never intended to be merged into Django, and was completely untested and likely buggy. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10784 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07Fixed #10585: comment redirects built from the `next` parameter now work ↵Jacob Kaplan-Moss
correctly when `next` already contains a query string. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10424 bcc190cf-cafb-0310-a4f2-bffc1f526a37