summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests')
-rw-r--r--tests/prefetch_related/models.py1
-rw-r--r--tests/prefetch_related/tests.py46
2 files changed, 44 insertions, 3 deletions
diff --git a/tests/prefetch_related/models.py b/tests/prefetch_related/models.py
index 0d9dbe6066..2f37cde1c8 100644
--- a/tests/prefetch_related/models.py
+++ b/tests/prefetch_related/models.py
@@ -35,6 +35,7 @@ class FavoriteAuthors(models.Model):
likes_author = models.ForeignKey(
Author, models.CASCADE, to_field="name", related_name="likes_me"
)
+ is_active = models.BooleanField(default=True)
class Meta:
ordering = ["id"]
diff --git a/tests/prefetch_related/tests.py b/tests/prefetch_related/tests.py
index 99e3cd6b80..b3531cc36f 100644
--- a/tests/prefetch_related/tests.py
+++ b/tests/prefetch_related/tests.py
@@ -3,7 +3,7 @@ from unittest import mock
from django.contrib.contenttypes.models import ContentType
from django.core.exceptions import ObjectDoesNotExist
from django.db import NotSupportedError, connection
-from django.db.models import Prefetch, QuerySet, prefetch_related_objects
+from django.db.models import F, Prefetch, QuerySet, prefetch_related_objects
from django.db.models.fields.related import ForwardManyToOneDescriptor
from django.db.models.query import get_prefetcher, prefetch_one_level
from django.db.models.sql import Query
@@ -364,7 +364,7 @@ class PrefetchRelatedTests(TestDataMixin, TestCase):
Query,
"add_q",
autospec=True,
- side_effect=lambda self, q: add_q(self, q),
+ side_effect=lambda self, q, reuse_all: add_q(self, q),
) as add_q_mock:
list(Book.objects.prefetch_related(relation))
self.assertEqual(add_q_mock.call_count, 1)
@@ -395,6 +395,46 @@ class PrefetchRelatedTests(TestDataMixin, TestCase):
with self.assertRaisesMessage(ValueError, msg):
Book.objects.prefetch_related("authors").iterator()
+ def test_m2m_join_reuse(self):
+ FavoriteAuthors.objects.bulk_create(
+ [
+ FavoriteAuthors(
+ author=self.author1, likes_author=self.author3, is_active=True
+ ),
+ FavoriteAuthors(
+ author=self.author1,
+ likes_author=self.author4,
+ is_active=False,
+ ),
+ FavoriteAuthors(
+ author=self.author2, likes_author=self.author3, is_active=True
+ ),
+ FavoriteAuthors(
+ author=self.author2, likes_author=self.author4, is_active=True
+ ),
+ ]
+ )
+ with self.assertNumQueries(2):
+ authors = list(
+ Author.objects.filter(
+ pk__in=[self.author1.pk, self.author2.pk]
+ ).prefetch_related(
+ Prefetch(
+ "favorite_authors",
+ queryset=(
+ Author.objects.annotate(
+ active_favorite=F("likes_me__is_active"),
+ ).filter(active_favorite=True)
+ ),
+ to_attr="active_favorite_authors",
+ )
+ )
+ )
+ self.assertEqual(authors[0].active_favorite_authors, [self.author3])
+ self.assertEqual(
+ authors[1].active_favorite_authors, [self.author3, self.author4]
+ )
+
class RawQuerySetTests(TestDataMixin, TestCase):
def test_basic(self):
@@ -1049,7 +1089,7 @@ class CustomPrefetchTests(TestCase):
Query,
"add_q",
autospec=True,
- side_effect=lambda self, q: add_q(self, q),
+ side_effect=lambda self, q, reuse_all: add_q(self, q),
) as add_q_mock:
list(
House.objects.prefetch_related(