diff options
Diffstat (limited to 'tests/urlpatterns_reverse')
| -rw-r--r-- | tests/urlpatterns_reverse/named_urls_conflict.py | 17 | ||||
| -rw-r--r-- | tests/urlpatterns_reverse/tests.py | 17 |
2 files changed, 34 insertions, 0 deletions
diff --git a/tests/urlpatterns_reverse/named_urls_conflict.py b/tests/urlpatterns_reverse/named_urls_conflict.py new file mode 100644 index 0000000000..0c0c6eb47e --- /dev/null +++ b/tests/urlpatterns_reverse/named_urls_conflict.py @@ -0,0 +1,17 @@ +from django.conf.urls import url + +from .views import empty_view + +urlpatterns = [ + # No kwargs + url(r'^conflict/cannot-go-here/$', empty_view, name='name-conflict'), + url(r'^conflict/$', empty_view, name='name-conflict'), + # One kwarg + url(r'^conflict-first/(?P<first>\w+)/$', empty_view, name='name-conflict'), + url(r'^conflict-cannot-go-here/(?P<middle>\w+)/$', empty_view, name='name-conflict'), + url(r'^conflict-middle/(?P<middle>\w+)/$', empty_view, name='name-conflict'), + url(r'^conflict-last/(?P<last>\w+)/$', empty_view, name='name-conflict'), + # Two kwargs + url(r'^conflict/(?P<another>\w+)/(?P<extra>\w+)/cannot-go-here/$', empty_view, name='name-conflict'), + url(r'^conflict/(?P<extra>\w+)/(?P<another>\w+)/$', empty_view, name='name-conflict'), +] diff --git a/tests/urlpatterns_reverse/tests.py b/tests/urlpatterns_reverse/tests.py index 8dbd57a27d..2cb933df37 100644 --- a/tests/urlpatterns_reverse/tests.py +++ b/tests/urlpatterns_reverse/tests.py @@ -382,6 +382,23 @@ class ResolverTests(SimpleTestCase): self.assertEqual(resolver.reverse('named-url2', 'arg'), 'extra/arg/') self.assertEqual(resolver.reverse('named-url2', extra='arg'), 'extra/arg/') + def test_resolver_reverse_conflict(self): + """ + url() name arguments don't need to be unique. The last registered + pattern takes precedence for conflicting names. + """ + resolver = get_resolver('urlpatterns_reverse.named_urls_conflict') + # Without arguments, the last URL in urlpatterns has precedence. + self.assertEqual(resolver.reverse('name-conflict'), 'conflict/') + # With an arg, the last URL in urlpatterns has precedence. + self.assertEqual(resolver.reverse('name-conflict', 'arg'), 'conflict-last/arg/') + # With a kwarg, other url()s can be reversed. + self.assertEqual(resolver.reverse('name-conflict', first='arg'), 'conflict-first/arg/') + self.assertEqual(resolver.reverse('name-conflict', middle='arg'), 'conflict-middle/arg/') + self.assertEqual(resolver.reverse('name-conflict', last='arg'), 'conflict-last/arg/') + # The number and order of the arguments don't interfere with reversing. + self.assertEqual(resolver.reverse('name-conflict', 'arg', 'arg'), 'conflict/arg/arg/') + def test_non_regex(self): """ A Resolver404 is raised if resolving doesn't meet the basic |