summaryrefslogtreecommitdiff
path: root/django/utils/http.py
diff options
context:
space:
mode:
Diffstat (limited to 'django/utils/http.py')
-rw-r--r--django/utils/http.py16
1 files changed, 11 insertions, 5 deletions
diff --git a/django/utils/http.py b/django/utils/http.py
index e18d8dd29c..1384b4294c 100644
--- a/django/utils/http.py
+++ b/django/utils/http.py
@@ -1,4 +1,5 @@
import re
+import sys
import urllib
from email.Utils import formatdate
@@ -73,14 +74,19 @@ def http_date(epoch_seconds=None):
def base36_to_int(s):
"""
- Converts a base 36 string to an ``int``. To prevent
- overconsumption of server resources, raises ``ValueError` if the
- input is longer than 13 base36 digits (13 digits is sufficient to
- base36-encode any 64-bit integer).
+ Converts a base 36 string to an ``int``. Raises ``ValueError` if the
+ input won't fit into an int.
"""
+ # To prevent overconsumption of server resources, reject any
+ # base36 string that is long than 13 base36 digits (13 digits
+ # is sufficient to base36-encode any 64-bit integer)
if len(s) > 13:
raise ValueError("Base36 input too large")
- return int(s, 36)
+ value = int(s, 36)
+ # ... then do a final check that the value will fit into an int.
+ if value > sys.maxint:
+ raise ValueError("Base36 input too large")
+ return value
def int_to_base36(i):
"""