summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--django/db/models/query_utils.py6
-rw-r--r--tests/regressiontests/queries/models.py8
2 files changed, 12 insertions, 2 deletions
diff --git a/django/db/models/query_utils.py b/django/db/models/query_utils.py
index 5ac08c0619..f6dc533c28 100644
--- a/django/db/models/query_utils.py
+++ b/django/db/models/query_utils.py
@@ -152,7 +152,8 @@ class Q(tree.Node):
def _combine(self, other, conn):
if not isinstance(other, Q):
raise TypeError(other)
- obj = deepcopy(self)
+ obj = type(self)()
+ obj.add(self, conn)
obj.add(other, conn)
return obj
@@ -163,7 +164,8 @@ class Q(tree.Node):
return self._combine(other, self.AND)
def __invert__(self):
- obj = deepcopy(self)
+ obj = type(self)()
+ obj.add(self, self.AND)
obj.negate()
return obj
diff --git a/tests/regressiontests/queries/models.py b/tests/regressiontests/queries/models.py
index f01e5f2c3e..22ae530613 100644
--- a/tests/regressiontests/queries/models.py
+++ b/tests/regressiontests/queries/models.py
@@ -5,6 +5,7 @@ Various complex queries that have been problematic in the past.
import datetime
import pickle
import sys
+import threading
from django.conf import settings
from django.db import models
@@ -44,6 +45,13 @@ class Note(models.Model):
def __unicode__(self):
return self.note
+ def __init__(self, *args, **kwargs):
+ super(Note, self).__init__(*args, **kwargs)
+ # Regression for #13227 -- having an attribute that
+ # is unpickleable doesn't stop you from cloning queries
+ # that use objects of that type as an argument.
+ self.lock = threading.Lock()
+
class Annotation(models.Model):
name = models.CharField(max_length=10)
tag = models.ForeignKey(Tag)