summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorDaniel Tao <daniel.tao@gmail.com>2017-09-15 16:16:44 -0500
committerTim Graham <timograham@gmail.com>2017-10-10 09:35:52 -0400
commitdc112bf530fe2fc3b9be82bb7a6e3213c5f7fc11 (patch)
treee5d0949b922cef20deaafbb5ea9b145bb2fa0233 /tests
parentd3e115151eaf1d7ce8d6402563f9ff7dd2a72180 (diff)
[2.0.x] Fixed #28601 -- Prevented cache.get_or_set() from caching None if default is a callable that returns None.
Backport of 4d60261b2a77460b4c127c3d832518b95e11a0ac from master
Diffstat (limited to 'tests')
-rw-r--r--tests/cache/tests.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/cache/tests.py b/tests/cache/tests.py
index e093dc842d..0549d790bc 100644
--- a/tests/cache/tests.py
+++ b/tests/cache/tests.py
@@ -926,6 +926,11 @@ class BaseCacheTests:
self.assertEqual(cache.get_or_set('mykey', my_callable), 'value')
self.assertEqual(cache.get_or_set('mykey', my_callable()), 'value')
+ def test_get_or_set_callable_returning_none(self):
+ self.assertIsNone(cache.get_or_set('mykey', lambda: None))
+ # Previous get_or_set() doesn't store None in the cache.
+ self.assertEqual(cache.get('mykey', 'default'), 'default')
+
def test_get_or_set_version(self):
msg = "get_or_set() missing 1 required positional argument: 'default'"
cache.get_or_set('brian', 1979, version=2)