summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorantoliny0919 <antoliny0919@gmail.com>2025-03-27 08:43:57 +0100
committerSarah Boyce <42296566+sarahboyce@users.noreply.github.com>2025-03-27 13:27:33 +0100
commit849f8307a5bb33465252d0891a9b2c47dde65889 (patch)
treeb3f634892a41bc531a076bc2dcaa82350a355c9c /tests
parent9aabe7eae3eeb3e64c5a0f3687118cd806158550 (diff)
Fixed #34917 -- Underlined links in the main content area of the admin.
Diffstat (limited to 'tests')
-rw-r--r--tests/admin_inlines/tests.py7
-rw-r--r--tests/admin_views/tests.py18
-rw-r--r--tests/auth_tests/test_forms.py7
-rw-r--r--tests/auth_tests/test_views.py4
4 files changed, 21 insertions, 15 deletions
diff --git a/tests/admin_inlines/tests.py b/tests/admin_inlines/tests.py
index 89f43300d7..63e7393853 100644
--- a/tests/admin_inlines/tests.py
+++ b/tests/admin_inlines/tests.py
@@ -1454,12 +1454,13 @@ class TestReadOnlyChangeViewInlinePermissions(TestCase):
response = self.client.get(self.change_url)
self.assertContains(
response,
- '<a href="/admin/admin_inlines/poll/" class="closelink">Close</a>',
+ '<a role="button" href="/admin/admin_inlines/poll/" class="closelink">'
+ "Close</a>",
html=True,
)
delete_link = (
- '<a href="/admin/admin_inlines/poll/%s/delete/" class="deletelink">Delete'
- "</a>"
+ '<a role="button" href="/admin/admin_inlines/poll/%s/delete/" '
+ 'class="deletelink">Delete</a>'
)
self.assertNotContains(response, delete_link % self.poll.id, html=True)
self.assertNotContains(
diff --git a/tests/admin_views/tests.py b/tests/admin_views/tests.py
index feafde47fd..b79b4a94a4 100644
--- a/tests/admin_views/tests.py
+++ b/tests/admin_views/tests.py
@@ -2683,8 +2683,8 @@ class AdminViewPermissionsTest(TestCase):
self.assertContains(response, "<label>Extra form field:</label>")
self.assertContains(
response,
- '<a href="/test_admin/admin/admin_views/article/" class="closelink">Close'
- "</a>",
+ '<a role="button" href="/test_admin/admin/admin_views/article/" '
+ 'class="closelink">Close</a>',
)
self.assertEqual(response.context["title"], "View article")
post = self.client.post(article_change_url, change_dict)
@@ -2835,8 +2835,8 @@ class AdminViewPermissionsTest(TestCase):
self.assertContains(response, "<h1>View article</h1>")
self.assertContains(
response,
- '<a href="/test_admin/admin9/admin_views/article/" class="closelink">Close'
- "</a>",
+ '<a role="button" href="/test_admin/admin9/admin_views/article/" '
+ 'class="closelink">Close</a>',
)
def test_change_view_save_as_new(self):
@@ -4056,7 +4056,8 @@ class AdminViewStringPrimaryKeyTest(TestCase):
args=(quote(self.pk),),
)
self.assertContains(
- response, '<a href="%s" class="historylink"' % escape(expected_link)
+ response,
+ '<a role="button" href="%s" class="historylink"' % escape(expected_link),
)
def test_redirect_on_add_view_continue_button(self):
@@ -8313,13 +8314,14 @@ class AdminKeepChangeListFiltersTests(TestCase):
# Check the history link.
history_link = re.search(
- '<a href="(.*?)" class="historylink">History</a>', response.text
+ '<a role="button" href="(.*?)" class="historylink">History</a>',
+ response.text,
)
self.assertURLEqual(history_link[1], self.get_history_url())
# Check the delete link.
delete_link = re.search(
- '<a href="(.*?)" class="deletelink">Delete</a>', response.text
+ '<a role="button" href="(.*?)" class="deletelink">Delete</a>', response.text
)
self.assertURLEqual(delete_link[1], self.get_delete_url())
@@ -8359,7 +8361,7 @@ class AdminKeepChangeListFiltersTests(TestCase):
self.client.force_login(viewuser)
response = self.client.get(self.get_change_url())
close_link = re.search(
- '<a href="(.*?)" class="closelink">Close</a>', response.text
+ '<a role="button" href="(.*?)" class="closelink">Close</a>', response.text
)
close_link = close_link[1].replace("&amp;", "&")
self.assertURLEqual(close_link, self.get_changelist_url())
diff --git a/tests/auth_tests/test_forms.py b/tests/auth_tests/test_forms.py
index 4740cb6200..0f8b48286a 100644
--- a/tests/auth_tests/test_forms.py
+++ b/tests/auth_tests/test_forms.py
@@ -1089,7 +1089,9 @@ class UserChangeFormTest(TestDataMixin, TestCase):
"Set password",
),
]
- password_reset_link = r'<a class="button" href="([^"]*)">([^<]*)</a>'
+ password_reset_link = (
+ r'<a role="button" class="button" href="([^"]*)">([^<]*)</a>'
+ )
for username, expected_help_text, expected_button_label in cases:
with self.subTest(username=username):
user = User.objects.get(username=username)
@@ -1438,7 +1440,8 @@ class ReadOnlyPasswordHashTest(SimpleTestCase):
" <strong>hash</strong>: "
" <bdi>WmCkn9**************************************</bdi>"
" </p>"
- ' <p><a class="button" href="../password/">Reset password</a></p>'
+ ' <p><a role="button" class="button" href="../password/">'
+ "Reset password</a></p>"
"</div>",
)
diff --git a/tests/auth_tests/test_views.py b/tests/auth_tests/test_views.py
index 1583f8ffd7..156520ebf7 100644
--- a/tests/auth_tests/test_views.py
+++ b/tests/auth_tests/test_views.py
@@ -1532,7 +1532,7 @@ class ChangelistTests(MessagesTestMixin, AuthViewsTestCase):
response = self.client.get(user_change_url)
# Test the link inside password field help_text.
rel_link = re.search(
- r'<a class="button" href="([^"]*)">Reset password</a>',
+ r'<a role="button" class="button" href="([^"]*)">Reset password</a>',
response.text,
)[1]
self.assertEqual(urljoin(user_change_url, rel_link), password_change_url)
@@ -1628,7 +1628,7 @@ class ChangelistTests(MessagesTestMixin, AuthViewsTestCase):
response = self.client.get(user_change_url)
# Test the link inside password field help_text.
rel_link = re.search(
- r'<a class="button" href="([^"]*)">Set password</a>',
+ r'<a role="button" class="button" href="([^"]*)">Set password</a>',
response.text,
)[1]
self.assertEqual(urljoin(user_change_url, rel_link), password_change_url)