summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorTim Graham <timograham@gmail.com>2016-12-31 12:43:30 -0500
committerTim Graham <timograham@gmail.com>2017-01-17 20:52:04 -0500
commit60ca37d2e56e435521a4aa5ba56b1b11cb2a78e5 (patch)
tree19fed3a6c8411aef6892b22032f4325014c78ee7 /tests
parent0dfc5479a8e50215866bbf43604bed8416a1b504 (diff)
Refs #24046 -- Removed mark_for_escaping() per deprecation timeline.
Diffstat (limited to 'tests')
-rw-r--r--tests/template_tests/filter_tests/test_chaining.py21
-rw-r--r--tests/template_tests/filter_tests/test_escape.py7
-rw-r--r--tests/template_tests/filter_tests/test_force_escape.py12
-rw-r--r--tests/utils_tests/test_safestring.py41
4 files changed, 10 insertions, 71 deletions
diff --git a/tests/template_tests/filter_tests/test_chaining.py b/tests/template_tests/filter_tests/test_chaining.py
index 1c12e252a0..9bc3976f37 100644
--- a/tests/template_tests/filter_tests/test_chaining.py
+++ b/tests/template_tests/filter_tests/test_chaining.py
@@ -1,8 +1,4 @@
-import warnings
-
-from django.test import SimpleTestCase, ignore_warnings
-from django.test.utils import reset_warning_registry
-from django.utils.deprecation import RemovedInDjango20Warning
+from django.test import SimpleTestCase
from django.utils.safestring import mark_safe
from ..utils import setup
@@ -42,20 +38,9 @@ class ChainingTests(SimpleTestCase):
# Using a filter that forces safeness does not lead to double-escaping
@setup({'chaining05': '{{ a|escape|capfirst }}'})
def test_chaining05(self):
- reset_warning_registry()
- with warnings.catch_warnings(record=True) as warns:
- warnings.simplefilter('always')
- output = self.engine.render_to_string('chaining05', {'a': 'a < b'})
- self.assertEqual(output, 'A &lt; b')
-
- self.assertEqual(len(warns), 1)
- self.assertEqual(
- str(warns[0].message),
- "escape isn't the last filter in ['escape_filter', 'capfirst'] and "
- "will be applied immediately in Django 2.0 so the output may change."
- )
+ output = self.engine.render_to_string('chaining05', {'a': 'a < b'})
+ self.assertEqual(output, 'A &lt; b')
- @ignore_warnings(category=RemovedInDjango20Warning)
@setup({'chaining06': '{% autoescape off %}{{ a|escape|capfirst }}{% endautoescape %}'})
def test_chaining06(self):
output = self.engine.render_to_string('chaining06', {'a': 'a < b'})
diff --git a/tests/template_tests/filter_tests/test_escape.py b/tests/template_tests/filter_tests/test_escape.py
index 644ed7ac9e..6f28b972a2 100644
--- a/tests/template_tests/filter_tests/test_escape.py
+++ b/tests/template_tests/filter_tests/test_escape.py
@@ -1,7 +1,6 @@
from django.template.defaultfilters import escape
-from django.test import SimpleTestCase, ignore_warnings
+from django.test import SimpleTestCase
from django.utils import six
-from django.utils.deprecation import RemovedInDjango20Warning
from django.utils.functional import Promise, lazy
from django.utils.safestring import mark_safe
@@ -24,15 +23,11 @@ class EscapeTests(SimpleTestCase):
output = self.engine.render_to_string('escape02', {"a": "x&y", "b": mark_safe("x&y")})
self.assertEqual(output, "x&amp;y x&y")
- # It is only applied once, regardless of the number of times it
- # appears in a chain (to be changed in Django 2.0).
- @ignore_warnings(category=RemovedInDjango20Warning)
@setup({'escape03': '{% autoescape off %}{{ a|escape|escape }}{% endautoescape %}'})
def test_escape03(self):
output = self.engine.render_to_string('escape03', {"a": "x&y"})
self.assertEqual(output, "x&amp;y")
- @ignore_warnings(category=RemovedInDjango20Warning)
@setup({'escape04': '{{ a|escape|escape }}'})
def test_escape04(self):
output = self.engine.render_to_string('escape04', {"a": "x&y"})
diff --git a/tests/template_tests/filter_tests/test_force_escape.py b/tests/template_tests/filter_tests/test_force_escape.py
index f163f2cd75..45f4efde62 100644
--- a/tests/template_tests/filter_tests/test_force_escape.py
+++ b/tests/template_tests/filter_tests/test_force_escape.py
@@ -2,8 +2,7 @@
from __future__ import unicode_literals
from django.template.defaultfilters import force_escape
-from django.test import SimpleTestCase, ignore_warnings
-from django.utils.deprecation import RemovedInDjango20Warning
+from django.test import SimpleTestCase
from django.utils.safestring import SafeData
from ..utils import setup
@@ -36,8 +35,7 @@ class ForceEscapeTests(SimpleTestCase):
self.assertEqual(output, "x&amp;amp;y")
# Because the result of force_escape is "safe", an additional
- # escape filter has no effect (to be changed in Django 2.0).
- @ignore_warnings(category=RemovedInDjango20Warning)
+ # escape filter has no effect.
@setup({'force-escape05': '{% autoescape off %}{{ a|force_escape|escape }}{% endautoescape %}'})
def test_force_escape05(self):
output = self.engine.render_to_string('force-escape05', {"a": "x&y"})
@@ -48,17 +46,15 @@ class ForceEscapeTests(SimpleTestCase):
output = self.engine.render_to_string('force-escape06', {"a": "x&y"})
self.assertEqual(output, "x&amp;y")
- @ignore_warnings(category=RemovedInDjango20Warning)
@setup({'force-escape07': '{% autoescape off %}{{ a|escape|force_escape }}{% endautoescape %}'})
def test_force_escape07(self):
output = self.engine.render_to_string('force-escape07', {"a": "x&y"})
- self.assertEqual(output, "x&amp;y")
+ self.assertEqual(output, "x&amp;amp;y")
- @ignore_warnings(category=RemovedInDjango20Warning)
@setup({'force-escape08': '{{ a|escape|force_escape }}'})
def test_force_escape08(self):
output = self.engine.render_to_string('force-escape08', {"a": "x&y"})
- self.assertEqual(output, "x&amp;y")
+ self.assertEqual(output, "x&amp;amp;y")
class FunctionTests(SimpleTestCase):
diff --git a/tests/utils_tests/test_safestring.py b/tests/utils_tests/test_safestring.py
index 6afcb3b1f7..abaf6a0596 100644
--- a/tests/utils_tests/test_safestring.py
+++ b/tests/utils_tests/test_safestring.py
@@ -1,14 +1,11 @@
from __future__ import unicode_literals
from django.template import Context, Template
-from django.test import SimpleTestCase, ignore_warnings
+from django.test import SimpleTestCase
from django.utils import html, six, text
-from django.utils.deprecation import RemovedInDjango20Warning
from django.utils.encoding import force_bytes
from django.utils.functional import lazy, lazystr
-from django.utils.safestring import (
- EscapeData, SafeData, mark_for_escaping, mark_safe,
-)
+from django.utils.safestring import SafeData, mark_safe
lazybytes = lazy(force_bytes, bytes)
@@ -63,40 +60,6 @@ class SafeStringTest(SimpleTestCase):
def test_mark_safe_lazy_result_implements_dunder_html(self):
self.assertEqual(mark_safe(lazystr('a&b')).__html__(), 'a&b')
- @ignore_warnings(category=RemovedInDjango20Warning)
- def test_mark_for_escaping(self):
- s = mark_for_escaping('a&b')
- self.assertRenderEqual('{{ s }}', 'a&amp;b', s=s)
- self.assertRenderEqual('{{ s }}', 'a&amp;b', s=mark_for_escaping(s))
-
- @ignore_warnings(category=RemovedInDjango20Warning)
- def test_mark_for_escaping_object_implementing_dunder_html(self):
- e = customescape('<a&b>')
- s = mark_for_escaping(e)
- self.assertIs(s, e)
-
- self.assertRenderEqual('{{ s }}', '<<a&b>>', s=s)
- self.assertRenderEqual('{{ s|force_escape }}', '&lt;a&amp;b&gt;', s=s)
-
- @ignore_warnings(category=RemovedInDjango20Warning)
- def test_mark_for_escaping_lazy(self):
- s = lazystr('a&b')
- b = lazybytes(b'a&b')
-
- self.assertIsInstance(mark_for_escaping(s), EscapeData)
- self.assertIsInstance(mark_for_escaping(b), EscapeData)
- self.assertRenderEqual('{% autoescape off %}{{ s }}{% endautoescape %}', 'a&amp;b', s=mark_for_escaping(s))
-
- @ignore_warnings(category=RemovedInDjango20Warning)
- def test_mark_for_escaping_object_implementing_dunder_str(self):
- class Obj(object):
- def __str__(self):
- return '<obj>'
-
- s = mark_for_escaping(Obj())
-
- self.assertRenderEqual('{{ s }}', '&lt;obj&gt;', s=s)
-
def test_add_lazy_safe_text_and_safe_text(self):
s = html.escape(lazystr('a'))
s += mark_safe('&b')