summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJon Dufresne <jon.dufresne@gmail.com>2019-04-28 06:15:19 -0700
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2019-04-29 08:05:07 +0200
commit5627057f63f30bda6bbef7e8169c2a6156542f90 (patch)
tree261b720dce737ce9a1efe4d0ef75a86cb65efd98 /tests
parentdbe436a9a916fb2bab788d07e22e7a79577738b9 (diff)
Refs #26022 -- Used context manager version of assertRaisesMessage in tests.
Follow up to 253adc2b8a52982139d40c4f55b3fd446e1cb8f3.
Diffstat (limited to 'tests')
-rw-r--r--tests/dates/tests.py8
-rw-r--r--tests/m2m_regress/tests.py6
-rw-r--r--tests/test_utils/tests.py6
3 files changed, 10 insertions, 10 deletions
diff --git a/tests/dates/tests.py b/tests/dates/tests.py
index ebdf05812e..82f21a2634 100644
--- a/tests/dates/tests.py
+++ b/tests/dates/tests.py
@@ -89,14 +89,12 @@ class DatesTests(TestCase):
Article.objects.dates()
def test_dates_fails_when_given_invalid_field_argument(self):
- self.assertRaisesMessage(
+ with self.assertRaisesMessage(
FieldError,
"Cannot resolve keyword 'invalid_field' into field. Choices are: "
"categories, comments, id, pub_date, pub_datetime, title",
- Article.objects.dates,
- "invalid_field",
- "year",
- )
+ ):
+ Article.objects.dates('invalid_field', 'year')
def test_dates_fails_when_given_invalid_kind_argument(self):
msg = "'kind' must be one of 'year', 'month', 'week', or 'day'."
diff --git a/tests/m2m_regress/tests.py b/tests/m2m_regress/tests.py
index b38ccf83be..c27fd8a6b2 100644
--- a/tests/m2m_regress/tests.py
+++ b/tests/m2m_regress/tests.py
@@ -34,11 +34,11 @@ class M2MRegressionTests(TestCase):
def test_internal_related_name_not_in_error_msg(self):
# The secret internal related names for self-referential many-to-many
# fields shouldn't appear in the list when an error is made.
- self.assertRaisesMessage(
+ with self.assertRaisesMessage(
FieldError,
"Choices are: id, name, references, related, selfreferchild, selfreferchildsibling",
- lambda: SelfRefer.objects.filter(porcupine='fred')
- )
+ ):
+ SelfRefer.objects.filter(porcupine='fred')
def test_m2m_inheritance_symmetry(self):
# Test to ensure that the relationship between two inherited models
diff --git a/tests/test_utils/tests.py b/tests/test_utils/tests.py
index e953eb6609..69a99d47d2 100644
--- a/tests/test_utils/tests.py
+++ b/tests/test_utils/tests.py
@@ -32,9 +32,11 @@ class SkippingTestCase(SimpleTestCase):
def _assert_skipping(self, func, expected_exc, msg=None):
try:
if msg is not None:
- self.assertRaisesMessage(expected_exc, msg, func)
+ with self.assertRaisesMessage(expected_exc, msg):
+ func()
else:
- self.assertRaises(expected_exc, func)
+ with self.assertRaises(expected_exc):
+ func()
except unittest.SkipTest:
self.fail('%s should not result in a skipped test.' % func.__name__)