summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorPaulo <commonzenpython@gmail.com>2017-06-03 18:13:38 -0400
committerTim Graham <timograham@gmail.com>2017-06-06 07:54:31 -0400
commit4ad2f862844d35404e4798b3227517625210a72e (patch)
treef7f746b502759cabb5b2aadbd04295ca3f820210 /tests
parent7f238097c0614707d6ee3fffbaf76f111b2fd38d (diff)
Fixed #28202 -- Fixed FieldListFilter.get_queryset() crash on invalid input.
Diffstat (limited to 'tests')
-rw-r--r--tests/admin_filters/tests.py8
-rw-r--r--tests/admin_views/admin.py2
2 files changed, 9 insertions, 1 deletions
diff --git a/tests/admin_filters/tests.py b/tests/admin_filters/tests.py
index 3f2f33bf3c..06b795b2db 100644
--- a/tests/admin_filters/tests.py
+++ b/tests/admin_filters/tests.py
@@ -6,6 +6,7 @@ from django.contrib.admin import (
AllValuesFieldListFilter, BooleanFieldListFilter, ModelAdmin,
RelatedOnlyFieldListFilter, SimpleListFilter, site,
)
+from django.contrib.admin.options import IncorrectLookupParameters
from django.contrib.admin.views.main import ChangeList
from django.contrib.auth.admin import UserAdmin
from django.contrib.auth.models import User
@@ -763,6 +764,13 @@ class ListFiltersTests(TestCase):
queryset = changelist.get_queryset(request)
self.assertEqual(list(queryset), [self.bio_book, self.djangonaut_book])
+ def test_fieldlistfilter_invalid_lookup_parameters(self):
+ """Filtering by an invalid value."""
+ modeladmin = BookAdmin(Book, site)
+ request = self.request_factory.get('/', {'author__id__exact': 'StringNotInteger!'})
+ with self.assertRaises(IncorrectLookupParameters):
+ self.get_changelist(request, Book, modeladmin)
+
def test_simplelistfilter(self):
modeladmin = DecadeFilterBookAdmin(Book, site)
diff --git a/tests/admin_views/admin.py b/tests/admin_views/admin.py
index 7c3190574c..cd323a10cf 100644
--- a/tests/admin_views/admin.py
+++ b/tests/admin_views/admin.py
@@ -165,7 +165,7 @@ class CustomArticleAdmin(admin.ModelAdmin):
class ThingAdmin(admin.ModelAdmin):
- list_filter = ('color__warm', 'color__value', 'pub_date',)
+ list_filter = ('color', 'color__warm', 'color__value', 'pub_date')
class InquisitionAdmin(admin.ModelAdmin):