summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2017-04-27 00:49:17 -0400
committerSimon Charette <charette.s@gmail.com>2017-05-11 21:50:07 -0400
commit4acae21846f6212aa992763e587c7e201828d7b0 (patch)
treebb2526ebca5fe788b71dd7c78013124c623866df /tests
parenta9874d48b1b9d91988b9f299726ec4f559fb2f75 (diff)
Fixed #24254 -- Fixed queries using the __in lookup with querysets using distinct() and order_by().
Thanks Tim for the review.
Diffstat (limited to 'tests')
-rw-r--r--tests/queries/tests.py30
1 files changed, 26 insertions, 4 deletions
diff --git a/tests/queries/tests.py b/tests/queries/tests.py
index 8bcf38f146..d1c1b2b4b0 100644
--- a/tests/queries/tests.py
+++ b/tests/queries/tests.py
@@ -2005,10 +2005,10 @@ class QuerysetOrderedTests(unittest.TestCase):
class SubqueryTests(TestCase):
@classmethod
def setUpTestData(cls):
- DumbCategory.objects.create(id=1)
- DumbCategory.objects.create(id=2)
- DumbCategory.objects.create(id=3)
- DumbCategory.objects.create(id=4)
+ NamedCategory.objects.create(id=1, name='first')
+ NamedCategory.objects.create(id=2, name='second')
+ NamedCategory.objects.create(id=3, name='third')
+ NamedCategory.objects.create(id=4, name='fourth')
def test_ordered_subselect(self):
"Subselects honor any manual ordering"
@@ -2064,6 +2064,28 @@ class SubqueryTests(TestCase):
DumbCategory.objects.filter(id__in=DumbCategory.objects.order_by('-id')[1:]).delete()
self.assertEqual(set(DumbCategory.objects.values_list('id', flat=True)), {3})
+ def test_distinct_ordered_sliced_subquery(self):
+ # Implicit values('id').
+ self.assertSequenceEqual(
+ NamedCategory.objects.filter(
+ id__in=NamedCategory.objects.distinct().order_by('name')[0:2],
+ ).order_by('name').values_list('name', flat=True), ['first', 'fourth']
+ )
+ # Explicit values('id').
+ self.assertSequenceEqual(
+ NamedCategory.objects.filter(
+ id__in=NamedCategory.objects.distinct().order_by('-name').values('id')[0:2],
+ ).order_by('name').values_list('name', flat=True), ['second', 'third']
+ )
+ # Annotated value.
+ self.assertSequenceEqual(
+ DumbCategory.objects.filter(
+ id__in=DumbCategory.objects.annotate(
+ double_id=F('id') * 2
+ ).order_by('id').distinct().values('double_id')[0:2],
+ ).order_by('id').values_list('id', flat=True), [2, 4]
+ )
+
class CloneTests(TestCase):