diff options
| author | Claude Paroz <claude@2xlibre.net> | 2018-02-06 11:51:41 +0100 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2018-04-02 10:20:00 -0400 |
| commit | 2a2ed0e70a93bfd1a3d41af40870fe963dc2687d (patch) | |
| tree | a23d1526aab1324798e431f78d9327c734a66a92 /tests | |
| parent | 09c6d0146178d83b6bd6cc8bb4162a5ae7c1c5f5 (diff) | |
Fixed #29116 -- Fixed OpenLayersWidget deserialization ignoring the widget map's SRID.
Regression in 6ecccad711b52f9273b1acb07a57d3f806e93928.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/gis_tests/test_geoforms.py | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/tests/gis_tests/test_geoforms.py b/tests/gis_tests/test_geoforms.py index cdcbe47685..1c221f10bc 100644 --- a/tests/gis_tests/test_geoforms.py +++ b/tests/gis_tests/test_geoforms.py @@ -1,7 +1,7 @@ import re from django.contrib.gis import forms -from django.contrib.gis.forms import BaseGeometryWidget +from django.contrib.gis.forms import BaseGeometryWidget, OpenLayersWidget from django.contrib.gis.geos import GEOSGeometry from django.forms import ValidationError from django.test import SimpleTestCase, override_settings @@ -31,8 +31,9 @@ class GeometryFieldTest(SimpleTestCase): fld = forms.GeometryField(srid=32140) tol = 0.0000001 xform_geom = GEOSGeometry('POINT (951640.547328465 4219369.26171664)', srid=32140) - # The cleaned geometry should be transformed to 32140. - cleaned_geom = fld.clean('SRID=4326;POINT (-95.363151 29.763374)') + # The cleaned geometry is transformed to 32140 (the widget map_srid is 3857). + cleaned_geom = fld.clean('SRID=3857;POINT (-10615777.40976205 3473169.895707852)') + self.assertEqual(cleaned_geom.srid, 32140) self.assertTrue(xform_geom.equals_exact(cleaned_geom, tol)) def test_null(self): @@ -83,6 +84,11 @@ class GeometryFieldTest(SimpleTestCase): with self.assertRaises(forms.ValidationError): fld.to_python(wkt) + def test_to_python_different_map_srid(self): + f = forms.GeometryField(widget=OpenLayersWidget) + json = '{ "type": "Point", "coordinates": [ 5.0, 23.0 ] }' + self.assertEqual(GEOSGeometry('POINT(5 23)', srid=f.widget.map_srid), f.to_python(json)) + def test_field_with_text_widget(self): class PointForm(forms.Form): pt = forms.PointField(srid=4326, widget=forms.TextInput) @@ -91,6 +97,8 @@ class GeometryFieldTest(SimpleTestCase): cleaned_pt = form.fields['pt'].clean('POINT(5 23)') self.assertEqual(cleaned_pt, GEOSGeometry('POINT(5 23)', srid=4326)) self.assertEqual(4326, cleaned_pt.srid) + with self.assertRaisesMessage(ValidationError, 'Invalid geometry value.'): + form.fields['pt'].clean('POINT(5)') point = GEOSGeometry('SRID=4326;POINT(5 23)') form = PointForm(data={'pt': 'POINT(5 23)'}, initial={'pt': point}) @@ -132,8 +140,9 @@ class GeometryFieldTest(SimpleTestCase): ' rows="10" name="pt3"></textarea>', output ) - # Only the invalid PNT(0) should trigger an error log entry - self.assertEqual(len(logger_calls), 1) + # Only the invalid PNT(0) triggers an error log entry. + # Deserialization is called in form clean and in widget rendering. + self.assertEqual(len(logger_calls), 2) self.assertEqual( logger_calls[0], "Error creating geometry from value 'PNT(0)' (String input " |
