summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorAymeric Augustin <aymeric.augustin@m4x.org>2014-04-09 22:20:22 +0200
committerAymeric Augustin <aymeric.augustin@m4x.org>2014-04-09 22:20:22 +0200
commit2791fbf59d85a20adac22ed73c88a97fc0350426 (patch)
treefd6d9336b50170eb830faf42251f53fea39222de /tests
parent11e7254c3dd788e0aefffcabac08f3542c9e1123 (diff)
Used more specific test assertions.
Diffstat (limited to 'tests')
-rw-r--r--tests/backends/tests.py4
-rw-r--r--tests/forms_tests/tests/test_forms.py4
-rw-r--r--tests/model_fields/tests.py2
3 files changed, 5 insertions, 5 deletions
diff --git a/tests/backends/tests.py b/tests/backends/tests.py
index c8c1875e26..ee1e56676f 100644
--- a/tests/backends/tests.py
+++ b/tests/backends/tests.py
@@ -646,7 +646,7 @@ class BackendTestCase(TestCase):
Test that cursors can be used as a context manager
"""
with connection.cursor() as cursor:
- self.assertTrue(isinstance(cursor, CursorWrapper))
+ self.assertIsInstance(cursor, CursorWrapper)
# Both InterfaceError and ProgrammingError seem to be used when
# accessing closed cursor (psycopg2 has InterfaceError, rest seem
# to use ProgrammingError).
@@ -661,7 +661,7 @@ class BackendTestCase(TestCase):
# psycopg2 offers us a way to check that by closed attribute.
# So, run only on psycopg2 for that reason.
with connection.cursor() as cursor:
- self.assertTrue(isinstance(cursor, CursorWrapper))
+ self.assertIsInstance(cursor, CursorWrapper)
self.assertTrue(cursor.closed)
diff --git a/tests/forms_tests/tests/test_forms.py b/tests/forms_tests/tests/test_forms.py
index d2e80d5b4d..2db40ef55c 100644
--- a/tests/forms_tests/tests/test_forms.py
+++ b/tests/forms_tests/tests/test_forms.py
@@ -1908,7 +1908,7 @@ class FormsTestCase(TestCase):
field = ChoicesField()
field2 = copy.deepcopy(field)
- self.assertTrue(isinstance(field2, ChoicesField))
+ self.assertIsInstance(field2, ChoicesField)
self.assertFalse(id(field2.fields) == id(field.fields))
self.assertFalse(id(field2.fields[0].choices) ==
id(field.fields[0].choices))
@@ -2152,7 +2152,7 @@ class FormsTestCase(TestCase):
e.append('Foo')
e.append(ValidationError('Foo%(bar)s', code='foobar', params={'bar': 'bar'}))
- self.assertTrue(isinstance(e, list))
+ self.assertIsInstance(e, list)
self.assertIn('Foo', e)
self.assertIn('Foo', forms.ValidationError(e))
diff --git a/tests/model_fields/tests.py b/tests/model_fields/tests.py
index 754ad20e5d..e8c798adc5 100644
--- a/tests/model_fields/tests.py
+++ b/tests/model_fields/tests.py
@@ -298,7 +298,7 @@ class BooleanFieldTests(unittest.TestCase):
# conversions are applied with an offset
b5 = BooleanModel.objects.all().extra(
select={'string_col': 'string'})[0]
- self.assertFalse(isinstance(b5.pk, bool))
+ self.assertNotIsInstance(b5.pk, bool)
def test_select_related(self):
"""