summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorMariusz Felisiak <felisiak.mariusz@gmail.com>2018-08-03 10:31:55 +0200
committerGitHub <noreply@github.com>2018-08-03 10:31:55 +0200
commit1a9cbf41a130def83a7e384955544d08be0fc148 (patch)
treee693a095b22b9533ba125c4c01afae72a8b71df9 /tests
parentd8e2be459f97f1773c7edf7d37de180139146176 (diff)
Fixed #29613 -- Fixed --keepdb on PostgreSQL if the database exists and the user can't create databases.
Regression in e776dd2db677d58dcb50aea20d3bb191537df25b. Thanks Tim Graham for the review.
Diffstat (limited to 'tests')
-rw-r--r--tests/backends/postgresql/test_creation.py13
1 files changed, 10 insertions, 3 deletions
diff --git a/tests/backends/postgresql/test_creation.py b/tests/backends/postgresql/test_creation.py
index 9f51d5e6b2..7d6f319a80 100644
--- a/tests/backends/postgresql/test_creation.py
+++ b/tests/backends/postgresql/test_creation.py
@@ -89,7 +89,14 @@ class DatabaseCreationTests(SimpleTestCase):
creation._create_test_db(verbosity=0, autoclobber=False, keepdb=True)
# Simulate test database creation raising unexpected error
with self.patch_test_db_creation(self._execute_raise_permission_denied):
- with self.assertRaises(SystemExit):
- creation._create_test_db(verbosity=0, autoclobber=False, keepdb=False)
- with self.assertRaises(SystemExit):
+ with mock.patch.object(DatabaseCreation, '_database_exists', return_value=False):
+ with self.assertRaises(SystemExit):
+ creation._create_test_db(verbosity=0, autoclobber=False, keepdb=False)
+ with self.assertRaises(SystemExit):
+ creation._create_test_db(verbosity=0, autoclobber=False, keepdb=True)
+ # Simulate test database creation raising "insufficient privileges".
+ # An error shouldn't appear when keepdb is on and the database already
+ # exists.
+ with self.patch_test_db_creation(self._execute_raise_permission_denied):
+ with mock.patch.object(DatabaseCreation, '_database_exists', return_value=True):
creation._create_test_db(verbosity=0, autoclobber=False, keepdb=True)