summaryrefslogtreecommitdiff
path: root/tests/utils_tests
diff options
context:
space:
mode:
authorSimon Charette <charette.s@gmail.com>2020-10-04 18:31:04 -0400
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2020-10-30 10:12:52 +0100
commit384ac0990ff414526ec47381845dae79b8e3ddfe (patch)
treeef21e47574574a7c79908cbfdcc72bfc2723d71a /tests/utils_tests
parenteb25fdb620f9fc3e2bcde916f9db2c06f53a3cd7 (diff)
Refs #32061 -- Prevented password leak on MySQL dbshell crash.
The usage of the --password flag when invoking the mysql CLI has the potential of exposing the password in plain text if the command happens to crash due to the inclusion of args provided to subprocess.run(check=True) in the string representation of the subprocess.CalledProcessError exception raised on non-zero return code. Since this has the potential of leaking the password to logging facilities configured to capture crashes (e.g. sys.excepthook, Sentry) it's safer to rely on the MYSQL_PWD environment variable instead even if its usage is discouraged due to potential leak through the ps command on old flavors of Unix. Thanks Charlie Denton for reporting the issue to the security team. Refs #24999.
Diffstat (limited to 'tests/utils_tests')
0 files changed, 0 insertions, 0 deletions