summaryrefslogtreecommitdiff
path: root/tests/urlpatterns
diff options
context:
space:
mode:
authorAdam Johnson <me@adamj.eu>2020-04-13 09:07:28 +0100
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2020-04-15 11:29:35 +0200
commit4bb33bb07450ea9b623877417c28e6489246f51c (patch)
treefa793b35e2e19ff79cd01803deb8e0487587df46 /tests/urlpatterns
parent578c03b276e435bcd3ce9eb17b81e85135c2d3f3 (diff)
Fixed #31459 -- Fixed handling invalid indentifiers in URL path conversion.
This patch adjusted existing tests that used invalid identifiers.
Diffstat (limited to 'tests/urlpatterns')
-rw-r--r--tests/urlpatterns/tests.py10
1 files changed, 9 insertions, 1 deletions
diff --git a/tests/urlpatterns/tests.py b/tests/urlpatterns/tests.py
index 0de0f6f05d..b6353873ae 100644
--- a/tests/urlpatterns/tests.py
+++ b/tests/urlpatterns/tests.py
@@ -249,7 +249,7 @@ class SameNameTests(SimpleTestCase):
class ParameterRestrictionTests(SimpleTestCase):
- def test_non_identifier_parameter_name_causes_exception(self):
+ def test_integer_parameter_name_causes_exception(self):
msg = (
"URL route 'hello/<int:1>/' uses parameter name '1' which isn't "
"a valid Python identifier."
@@ -257,6 +257,14 @@ class ParameterRestrictionTests(SimpleTestCase):
with self.assertRaisesMessage(ImproperlyConfigured, msg):
path(r'hello/<int:1>/', lambda r: None)
+ def test_non_identifier_parameter_name_causes_exception(self):
+ msg = (
+ "URL route 'b/<int:book.id>/' uses parameter name 'book.id' which "
+ "isn't a valid Python identifier."
+ )
+ with self.assertRaisesMessage(ImproperlyConfigured, msg):
+ path(r'b/<int:book.id>/', lambda r: None)
+
def test_allows_non_ascii_but_valid_identifiers(self):
# \u0394 is "GREEK CAPITAL LETTER DELTA", a valid identifier.
p = path('hello/<str:\u0394>/', lambda r: None)