summaryrefslogtreecommitdiff
path: root/tests/regressiontests
diff options
context:
space:
mode:
authorAlex Gaynor <alex.gaynor@gmail.com>2012-08-15 02:04:40 -0700
committerAlex Gaynor <alex.gaynor@rd.io>2012-08-15 02:05:03 -0700
commitdfbcbf212493b9e5bb527e7ec2d97ae3cec480fa (patch)
tree6cf4d3947466a45900203e9cdcdc130955cb8948 /tests/regressiontests
parente0d67f3440b3b2c854da013fd1f9894477e26a77 (diff)
Always close files in the file_storage tests.
Diffstat (limited to 'tests/regressiontests')
-rw-r--r--tests/regressiontests/file_storage/tests.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/regressiontests/file_storage/tests.py b/tests/regressiontests/file_storage/tests.py
index 31e33d915c..b5eb5601f3 100644
--- a/tests/regressiontests/file_storage/tests.py
+++ b/tests/regressiontests/file_storage/tests.py
@@ -197,8 +197,8 @@ class FileStorageTests(unittest.TestCase):
ContentFile(b'file saved with path'))
self.assertTrue(self.storage.exists('path/to'))
- self.assertEqual(self.storage.open('path/to/test.file').read(),
- b'file saved with path')
+ with self.storage.open('path/to/test.file') as f:
+ self.assertEqual(f.read(), b'file saved with path')
self.assertTrue(os.path.exists(
os.path.join(self.temp_dir, 'path', 'to', 'test.file')))
@@ -305,13 +305,13 @@ class FileStorageTests(unittest.TestCase):
self.storage.save('normal/test.file',
ContentFile(b'saved normally'))
- self.assertEqual(self.storage.open('normal/test.file').read(),
- b'saved normally')
+ with self.storage.open('normal/test.file') as f:
+ self.assertEqual(f.read(), b'saved normally')
self.storage.save('raced/test.file',
ContentFile(b'saved with race'))
- self.assertEqual(self.storage.open('raced/test.file').read(),
- b'saved with race')
+ with self.storage.open('raced/test.file') as f:
+ self.assertEqual(f.read(), b'saved with race')
# Check that OSErrors aside from EEXIST are still raised.
self.assertRaises(OSError,